From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8877028E1 for ; Wed, 13 Jul 2022 10:24:45 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id bp17so10472819lfb.3 for ; Wed, 13 Jul 2022 03:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=PQ7TlErz9smov0rfx19Na+1VuDOymVWccAObGubD7hE=; b=j3Im0x2bE4D19GrrzFvEHiywctG624H/V6PfGPXeeKLO89ES02QmxTzGtZiHoSfIIt WQo8N59T2vYLPAiWh1ERS+CrQ9vxZBCNvCvU+KvuTIlx1M/nz1kBTeif1g8+mTRj4P+j ZfZVvzS5GEqgZ26cUr8/o34YBYoTItxb6hJze7yK33Z4zmygVaSrOj9nE+/ZmUn509G2 B+XGIYZWMD7Pp9QwwIrjFvEJsH09twOKr/GGqBORBJfmMhXv+bpSVlh8BKatiMg4LjPM Q+R3zzd0vuxbJgKsJ08pDTK4ivem9OatHJqy8v3a/Ovaj1kwIkPWE/UV+QuKb9pZ34w0 4tew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PQ7TlErz9smov0rfx19Na+1VuDOymVWccAObGubD7hE=; b=Qlge/FtIlWDTfOBEEkKrcSxOlWO1u2adaJKfFwOKBEaiQ0FrbHpBWMluln+p6vXF35 DndAkIt3Olw0xiOZyE7YxuDuXUYN3sad1eKfSlsirQ2momwZxQceOWflSRa+ebKUVQNn d+G1xmNIc2lJVUaWCnpA+CFrCXDUriDzgiUeaXwTpyIPX8se82u2iiyG+OLadsX3ewZ4 ZAQjTJmlP7xxo77zSfkw3ZsXYJiP+tFHe9YDc9Q/Ac0Dvh3KA8eWTCcztSq1Qf6j2yc4 QH0cpzHxP97YMuVBEQbTRZrGGdHpIBK0Fu+ILNvDA24VoQbAFJKvu+kic3STx9QqfXl7 qx4A== X-Gm-Message-State: AJIora+5zWJXi/Uz8aqGjcieIJhp1VO0Uou1z7WF9CsafZJNo1xfzLAV U7wsXtDPoTX6tv8bR5InVzg= X-Google-Smtp-Source: AGRyM1skQh9Jgh7G2eTiKQGhgpSh87g4zJf6atlVqh7gkzR/TrDYVBtdFIgudz1CX+zJh/nVmujKPw== X-Received: by 2002:a05:6512:2254:b0:489:d168:20cf with SMTP id i20-20020a056512225400b00489d16820cfmr1537677lfu.97.1657707883409; Wed, 13 Jul 2022 03:24:43 -0700 (PDT) Received: from [192.168.1.11] ([46.235.67.63]) by smtp.gmail.com with ESMTPSA id a28-20020a2eb17c000000b0025d3c2e6b8dsm2943803ljm.105.2022.07.13.03.24.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 03:24:42 -0700 (PDT) Message-ID: <5445d915-0c6c-b84f-158e-160e7645cbbd@gmail.com> Date: Wed, 13 Jul 2022 13:24:41 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] staging: r888eu: use dynamic allocation for efuse buffer Content-Language: en-US To: Martin Kaiser , Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter References: <20220713075804.140986-1-martin@kaiser.cx> From: Pavel Skripkin In-Reply-To: <20220713075804.140986-1-martin@kaiser.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Martin, Martin Kaiser says: > Use kmalloc to allocate the efuse buffer in ReadAdapterInfo8188EU and > free it on exit. This is better than using a 512 byte array on the stack. > > It's ok to drop the __aligned(4) qualifier. kmalloc aligns to > ARCH_KMALLOC_MINALIGN, this is at least 8 bytes. > > Suggested-by: Dan Carpenter > Suggested-by: Larry Finger > Signed-off-by: Martin Kaiser > --- > drivers/staging/r8188eu/hal/usb_halinit.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c > index 8902dda7b8d8..421fe7c40390 100644 > --- a/drivers/staging/r8188eu/hal/usb_halinit.c > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c > @@ -926,7 +926,7 @@ void ReadAdapterInfo8188EU(struct adapter *Adapter) > { > struct eeprom_priv *eeprom = &Adapter->eeprompriv; > struct led_priv *ledpriv = &Adapter->ledpriv; > - u8 efuse_buf[EFUSE_MAP_LEN_88E] __aligned(4); > + u8 *efuse_buf; > u8 eeValue; > int res; > > @@ -937,7 +937,10 @@ void ReadAdapterInfo8188EU(struct adapter *Adapter) > > eeprom->bautoload_fail_flag = !(eeValue & EEPROM_EN); > > - memset(efuse_buf, 0xFF, sizeof(efuse_buf)); > + efuse_buf = kmalloc(EFUSE_MAP_LEN_88E, GFP_KERNEL); > + if (!efuse_buf) > + return; I think, it worth returning an error to caller. Functions right after the allocation do initialization, so leaving fields as-is seems to be dangerous Thanks, --Pavel Skripkin