From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C2462C83 for ; Mon, 15 Nov 2021 14:46:26 +0000 (UTC) Received: by mail-lj1-f173.google.com with SMTP id t11so36076233ljh.6 for ; Mon, 15 Nov 2021 06:46:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f9990VLRY1mM2sii4oucAgZqtJr4f6UTn2nlUsBeiyA=; b=MKv4lJzovSleVVtb8Uez4QS8nWVoyslVc4dAhZ3Ja9hcfOWhdQeyMWw6FHhrLjYpMe nYJhoHPJHieO78N1tejBSn1JjrO7HehrBzOD6p80ebHQ/GkZbHzj+oDCc5U4EAGGyBKV xbJLawSqjqY4fBNx9jKlTQhw4P401MYqth7VhZkzSxvdhwOw2g0BxwUpHsNeyVoCEXwg AneGSb38fLLRS0lfd/WXUhHjDQTfopD289+UYtNAyG6eoU7lhx2ZHI9h8rOgSDINeyOy BSHVlS4ECWcjRF5ej1E2mdUBpiNe11q16/40ayNE4SINNFWYIMy3ZhzwXNTN4fPHDK38 wMxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f9990VLRY1mM2sii4oucAgZqtJr4f6UTn2nlUsBeiyA=; b=cjOukstuxWqz5wyumeWIgqcdDAuGdPV7YxJ88x++oaoRS0jgII4tRHoQN6GocO4KsW K0JWhk+cXqQeCtywMQkj/fimZUInO5NYmPekTySc11R7+hFuizhzYP6maGExr8hrrEgt wYC4DQnsetXt3R3q5/4FNySMSF2/xHg79c+Kv8Ks+FKznDnA9Zen2gyXqUBr8xuhdBut Wa8cMhyWTxRLsWOxkR+pYrpFWYETh0T0eW6kdQZ+3uH/Aw0DrucJhPkbfbQ2HGG2FInS NLezasDGcGkWZzjRuJVGJlihFWv4b/WvRDs51TMmWNIhWsgucV9EMf0UU3qfkXTRwLAf egxQ== X-Gm-Message-State: AOAM530821LTQh6TNSTPCsPofXnEImHrT1foigSkcQa7mjB/5uYMC8GF v3/rTCHYjXkjBYXSXOXeY88= X-Google-Smtp-Source: ABdhPJyGzX+uJoClUoX59O9YRdwTgWzR3XA1e/9PtaHs0iyNVaYjGst0rpo/clkWJ4amyTD6J2hiFA== X-Received: by 2002:a2e:b711:: with SMTP id j17mr29887114ljo.39.1636987584324; Mon, 15 Nov 2021 06:46:24 -0800 (PST) Received: from [192.168.2.145] (46-138-46-211.dynamic.spd-mgts.ru. [46.138.46.211]) by smtp.googlemail.com with ESMTPSA id j2sm1445777lfr.109.2021.11.15.06.46.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Nov 2021 06:46:24 -0800 (PST) Subject: Re: [PATCH 01/11] ASoC: dai_dma: remove slave_id field To: Lars-Peter Clausen , Arnd Bergmann Cc: Vinod Koul , Arnd Bergmann , Andy Gross , Andy Shevchenko , Baolin Wang , Bjorn Andersson , Chunyan Zhang , Greg Kroah-Hartman , Hyun Kwon , Jaroslav Kysela , Jon Hunter , Laurent Pinchart , Laxman Dewangan , Manivannan Sadhasivam , Mark Brown , Michal Simek , Nicolas Saenz Julienne , Orson Zhai , Robert Jarzmik , Scott Branden , Takashi Iwai , Thierry Reding , ALSA Development Mailing List , bcm-kernel-feedback-list , dmaengine@vger.kernel.org, dri-devel , Linux ARM , linux-arm-msm , Linux Kernel Mailing List , linux-mmc , linux-mtd , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "open list:SERIAL DRIVERS" , linux-spi , linux-staging@lists.linux.dev, "open list:TEGRA ARCHITECTURE SUPPORT" References: <20211115085403.360194-1-arnd@kernel.org> <20211115085403.360194-2-arnd@kernel.org> <647b842d-76a1-7a96-3ea7-8a37b62bc18e@metafoo.de> From: Dmitry Osipenko Message-ID: <5737810c-420a-2f8d-99bf-24a2558d5855@gmail.com> Date: Mon, 15 Nov 2021 17:46:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit 15.11.2021 14:53, Lars-Peter Clausen пишет: > On 11/15/21 11:42 AM, Arnd Bergmann wrote: >> On Mon, Nov 15, 2021 at 11:14 AM Lars-Peter Clausen >> wrote: >>> On 11/15/21 9:53 AM, Arnd Bergmann wrote: >>>> From: Arnd Bergmann >>>> >>>> This field is never set, and serves no purpose, so remove it. >>> I agree that we should remove it. Its been legacy support code for a >>> while, but the description that there is no user is not right. >>> >>> The tegra20_spdif driver obviously uses it and that user is removed in >>> this patch. I think it makes sense to split that out into a separate >>> patch with a description why the driver will still work even with >>> slave_id removed. Maybe the best is to remove the whole tegra20_spdif >>> driver. >> Ok, I'll split out the tegra patch and try to come up with a better >> description for it. What I saw in that driver is it just passes down the >> slave_id number from a 'struct resource', but there is nothing in >> the kernel that sets up this resource. >> >> Do you or someone else have more information on the state of this >> driver? I can see that it does not contain any of_device_id based >> probing, so it seems that this is either dead code, the platform_device >> gets created by some other code that is no longer compatible with >> this driver. > > I've looked into this a while back, when I tried to remove slave_id. And > as far as I can tell there were never any in-tree users of this driver, > even back when we used platform board files. Maybe somebody from Nvidia > knows if there are out-of-tree users. That Tegra SPDIF driver was never used. Still there is a growing interest nowadays in making it alive by implementing HDMI audio support for Tegra20 SoC. It was on my todo list for a long time, I'll try to prioritize that work 5.17, it shouldn't take much effort. The slave_id should be removed anyways, it won't be needed.