From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1F9768; Fri, 19 Nov 2021 15:53:44 +0000 (UTC) Received: by mail-wr1-f42.google.com with SMTP id s13so18941830wrb.3; Fri, 19 Nov 2021 07:53:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kHaNRUFisXjYgHBC5B676Xg2I2fpmEyhpkjhdGVDAKM=; b=ZdsrF1YMpdZEaLIT879zO5XP/0/GIL8TxMBkQ+oBsQDHC1XffTe15Xo3zOi3CfQsIW SfVZp4yHJp3z6FO0MsoJXz0l5pt72hEQWvDyTiTNXJ65m72213zH2YphOawDgUHrqFZg tf1fwGadrOC01WL4AAOUCOhNnAIBOhdtZDBp3yH4MwsBVM9OKuO6vgyh1H8JHe9c3xY1 UcZo8yTpxG5QeCXLSEf6W72WVbX+H0+LNvX6UNtwHB7Trtj91sRqcosYwE/7fDXi08aS XGvGFyrXuKCwi0OFOk6jB9JJC6OpJTiJYJKoFXtDW03cMkWwti8iZlRh1DJ1Q3TKYKQR epJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kHaNRUFisXjYgHBC5B676Xg2I2fpmEyhpkjhdGVDAKM=; b=BPbg8Y+I7IDKX2STe0BgA5rXI9Gw257FSJMToRwAZt24vd/+wXt0OuCIiyLp97Vw6g KEJyHTRuAL7BnQZM3VzMvg4r5qFRYtRmd9jLcuEKOre3WUWdW5tA5ubw1fTYrNb2ggP4 km8M+aGcfXtJp+OQ90R9BCbFxmm2Yr1Bl60tAaoJRBZ/aDOsW+TgIPXjS6yif8maG5hg zWxo5209GhENtaqHJpY2n6ifao5JSLT2R6g3gXnyP+NAHitUQ4+zX7D6khXEf7EAKQ2u SfZUrHwqo1iC/UpMOEH8D+hAGz1cFwQsnH60aS9ddhPnjI3TRmHLLlKNVqj50CH7wZHt IsRQ== X-Gm-Message-State: AOAM530uagcFitMh1C+6zRmPon6DdKEuAzes4TlRg/muvsDucI7b2IoJ +pOQaNJC1A3jaPaMBExIHxA= X-Google-Smtp-Source: ABdhPJwoTWQYUCPa9Te8PwG+K8gFrG5i33W0fugyKvlgWtaRFt6efNHW+zbBPrEgEzqCPEArSG3Bvw== X-Received: by 2002:a5d:69ce:: with SMTP id s14mr8340988wrw.25.1637337222991; Fri, 19 Nov 2021 07:53:42 -0800 (PST) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id m2sm12397317wml.15.2021.11.19.07.53.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 07:53:42 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Paul Kocialkowski , Mauro Carvalho Chehab , linux-media@vger.kernel.org, Samuel Holland Cc: Rob Herring , devicetree@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi@lists.linux.dev, Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-staging@lists.linux.dev Subject: Re: [PATCH 2/2] media: cedrus: Add support for the D1 variant Date: Fri, 19 Nov 2021 16:53:41 +0100 Message-ID: <5766379.lOV4Wx5bFT@kista> In-Reply-To: <20211119031519.23430-2-samuel@sholland.org> References: <20211119031519.23430-1-samuel@sholland.org> <20211119031519.23430-2-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Samuel! Dne petek, 19. november 2021 ob 04:15:18 CET je Samuel Holland napisal(a): > D1 has a unique variant of the video engine, which appears to drop the > VP8 support found on most earlier variants. > > Signed-off-by: Samuel Holland > --- > > drivers/staging/media/sunxi/cedrus/cedrus.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/ media/sunxi/cedrus/cedrus.c > index c76fc97d97a0..4a4b714b0f26 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c > @@ -580,6 +580,14 @@ static const struct cedrus_variant sun8i_r40_cedrus_variant = { > .mod_rate = 297000000, > }; > > +static const struct cedrus_variant sun20i_d1_cedrus_variant = { > + .capabilities = CEDRUS_CAPABILITY_UNTILED | > + CEDRUS_CAPABILITY_MPEG2_DEC | > + CEDRUS_CAPABILITY_H264_DEC | > + CEDRUS_CAPABILITY_H265_DEC, Did you check if VP8 really doesn't work? It would be strange because it shares decoding blocks with H264 and VP8 is present in (almost) all SoCs. Best regards, Jernej > + .mod_rate = 432000000, > +}; > + > static const struct cedrus_variant sun50i_a64_cedrus_variant = { > .capabilities = CEDRUS_CAPABILITY_UNTILED | > CEDRUS_CAPABILITY_MPEG2_DEC | > @@ -637,6 +645,10 @@ static const struct of_device_id cedrus_dt_match[] = { > .compatible = "allwinner,sun8i-r40-video-engine", > .data = &sun8i_r40_cedrus_variant, > }, > + { > + .compatible = "allwinner,sun20i-d1-video-engine", > + .data = &sun20i_d1_cedrus_variant, > + }, > { > .compatible = "allwinner,sun50i-a64-video-engine", > .data = &sun50i_a64_cedrus_variant, > -- > 2.32.0 > >