From: Dan Carpenter <dan.carpenter@linaro.org>
To: Kartik Kulkarni <kartik.koolks@gmail.com>
Cc: hdegoede@redhat.com, mchehab@kernel.org,
akari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, ~lkcamp/patches@lists.sr.ht,
helen.koike@collabora.com
Subject: Re: [PATCH] staging: atomisp: bnr: fix trailing statement
Date: Tue, 30 Jul 2024 10:43:08 -0500 [thread overview]
Message-ID: <582189dd-48ee-4ca5-87ca-dd640b09f18b@suswa.mountain> (raw)
In-Reply-To: <20240730123842.37487-1-kartik.koolks@gmail.com>
On Tue, Jul 30, 2024 at 12:38:42PM +0000, Kartik Kulkarni wrote:
> Fix checkpatch error trailing statements should be on next line in
> ia_css_bnr.host.c:48.
> ---
> Newbie to contributing to kernel code
> ---
>
> Signed-off-by: Kartik Kulkarni <kartik.koolks@gmail.com>
This signed off by line needs to go above the --- line.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
prev parent reply other threads:[~2024-07-30 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 12:38 [PATCH] staging: atomisp: bnr: fix trailing statement Kartik Kulkarni
2024-07-30 15:43 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582189dd-48ee-4ca5-87ca-dd640b09f18b@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=akari.ailus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=helen.koike@collabora.com \
--cc=kartik.koolks@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox