From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Dragan Cvetic <dragan.m.cvetic@gmail.com>, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Rename Tx_Retry_Count_Reg
Date: Sun, 25 Sep 2022 21:26:35 +0200 [thread overview]
Message-ID: <59255558-06ed-d82f-3e72-f1ccf03ba96d@gmail.com> (raw)
In-Reply-To: <20220924225126.10527-1-dragan.m.cvetic@gmail.com>
On 9/25/22 00:51, Dragan Cvetic wrote:
> Rename: Current_Tx_Rate_Reg to CURRENT_TX_RATE_REG, Initial_Tx_Rate_Reg to
> INITIAL_TX_RATE_REG and Tx_Retry_Count_Reg to TX_RETRY_COUNT_REG to avoid
> CamelCase which is not accepted by checkpatch.pl.
>
> Signed-off-by: Dragan Cvetic <dragan.m.cvetic@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 11 +++--------
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 6 +++---
> 2 files changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index 3ee52147960e..9fefa1a7ae75 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> @@ -2499,14 +2499,9 @@ static void _rtl92e_dm_check_txrateandretrycount(struct net_device *dev)
> struct r8192_priv *priv = rtllib_priv(dev);
> struct rtllib_device *ieee = priv->rtllib;
>
> - ieee->softmac_stats.CurrentShowTxate = rtl92e_readb(dev,
> - Current_Tx_Rate_Reg);
> -
> - ieee->softmac_stats.last_packet_rate = rtl92e_readb(dev,
> - Initial_Tx_Rate_Reg);
> -
> - ieee->softmac_stats.txretrycount = rtl92e_readl(dev,
> - Tx_Retry_Count_Reg);
> + ieee->softmac_stats.CurrentShowTxate = rtl92e_readb(dev, CURRENT_TX_RATE_REG);
> + ieee->softmac_stats.last_packet_rate = rtl92e_readb(dev, INITIAL_TX_RATE_REG);
> + ieee->softmac_stats.txretrycount = rtl92e_readl(dev, TX_RETRY_COUNT_REG);
> }
>
> static void _rtl92e_dm_send_rssi_to_fw(struct net_device *dev)
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
> index ea1b14bbcdcd..51e295d389a8 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
> @@ -42,9 +42,9 @@
> #define TX_POWER_ATHEROAP_THRESH_HIGH 78
> #define TX_POWER_ATHEROAP_THRESH_LOW 72
>
> -#define Current_Tx_Rate_Reg 0x1e0
> -#define Initial_Tx_Rate_Reg 0x1e1
> -#define Tx_Retry_Count_Reg 0x1ac
> +#define CURRENT_TX_RATE_REG 0x1e0
> +#define INITIAL_TX_RATE_REG 0x1e1
> +#define TX_RETRY_COUNT_REG 0x1ac
> #define RegC38_TH 20
>
> #define DM_Type_ByDriver 1
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
prev parent reply other threads:[~2022-09-25 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 22:51 [PATCH] staging: rtl8192e: Rename Tx_Retry_Count_Reg Dragan Cvetic
2022-09-25 19:26 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59255558-06ed-d82f-3e72-f1ccf03ba96d@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=dragan.m.cvetic@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox