public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 20/25] staging: rtl8723bs: put constant on the right side of a test in os_dep/ioctl_cfg80211.c
Date: Sat, 10 Apr 2021 16:20:33 +0200	[thread overview]
Message-ID: <5ac547f3a4bd228f372da7057bbfb3cac1535857.1618064274.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1618064274.git.fabioaiuto83@gmail.com>

fix following post-commit hook checkpatch issue:

CHECK: Comparison to NULL could be written "psta"
72: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:854:
+			if (psta != NULL) {

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 4014b692d954..617c88c6e4e7 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -851,7 +851,7 @@ static int rtw_cfg80211_set_encryption(struct net_device *dev, struct ieee_param
 		if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_MP_STATE) == true) /* sta mode */
 		{
 			psta = rtw_get_stainfo(pstapriv, get_bssid(pmlmepriv));
-			if (psta != NULL) {
+			if (psta) {
 				/* Jeff: don't disable ieee8021x_blocked while clearing key */
 				if (strcmp(param->u.crypt.alg, "none") != 0)
 					psta->ieee8021x_blocked = false;
-- 
2.20.1


  parent reply	other threads:[~2021-04-10 14:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 14:20 [PATCH 00/25] staging: rtl8723bs: remove DBG_8192C tracing macro Fabio Aiuto
2021-04-10 14:20 ` [PATCH 01/25] staging: rtl8723bs: remove all DBG_8192C logs Fabio Aiuto
2021-04-10 14:20 ` [PATCH 02/25] staging: rtl8723bs: remove all commented out " Fabio Aiuto
2021-04-10 14:20 ` [PATCH 03/25] staging: rtl8723bs: remove DBG_8192C macro definitions Fabio Aiuto
2021-04-10 14:20 ` [PATCH 04/25] staging: rtl8723bs: remove all if-blocks left empty by DBG_8192C-remove coccinelle script Fabio Aiuto
2021-04-10 14:20 ` [PATCH 05/25] staging: rtl8723bs: put spaces around operators Fabio Aiuto
2021-04-10 14:20 ` [PATCH 06/25] staging: rtl8723bs: remove unused code blocks guarded by DEBUG_RTL871X Fabio Aiuto
2021-04-10 14:20 ` [PATCH 07/25] staging: rtl8723bs: remove commented out DEBUG_RTL871X definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 08/25] staging: rtl8723bs: remove code blocks guarded by DEBUG symbol Fabio Aiuto
2021-04-10 14:20 ` [PATCH 09/25] staging: rtl8723bs: remove empty code block guarded by DBG_CCX Fabio Aiuto
2021-04-10 14:20 ` [PATCH 10/25] staging: rtl8723bs: remove code block guarded by undefined SDIO_DEBUG_IO Fabio Aiuto
2021-04-10 14:20 ` [PATCH 11/25] staging: rtl8723bs: remove commented out SDIO_DEBUG_IO symbol definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 12/25] staging: rtl8723bs: remove empty ifdef blocks conditioned to DEBUG_CFG80211 definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 13/25] staging: rtl8723bs: remove commented out DEBUG_CFG80211 symbol definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 14/25] staging: rtl8723bs: remove unnecessary bracks Fabio Aiuto
2021-04-10 14:20 ` [PATCH 15/25] staging: rtl8723bs: fix comparison to null Fabio Aiuto
2021-04-10 14:20 ` [PATCH 16/25] staging: rtl8723bs: put spaces around operators Fabio Aiuto
2021-04-10 14:20 ` [PATCH 17/25] staging: rtl8723bs: split long line Fabio Aiuto
2021-04-10 14:20 ` [PATCH 18/25] staging: rtl8723bs: put constant on the right side of the test Fabio Aiuto
2021-04-10 14:20 ` [PATCH 19/25] staging: rtl8723bs: remove empty if and else blocks Fabio Aiuto
2021-04-10 14:20 ` Fabio Aiuto [this message]
2021-04-10 14:20 ` [PATCH 21/25] staging: rtl8723bs: remove unnecessary parentheses in os_dep/ioctl_cfg80211.c Fabio Aiuto
2021-04-10 14:20 ` [PATCH 22/25] staging: rtl8723bs: remove empty else block " Fabio Aiuto
2021-04-10 14:20 ` [PATCH 23/25] staging: rtl8723bs: fix comparison to true issue Fabio Aiuto
2021-04-10 14:20 ` [PATCH 24/25] staging: rtl8723bs: remove more unnecessary parentheses Fabio Aiuto
2021-04-10 14:20 ` [PATCH 25/25] staging: rtl8723bs: remove more empty if blocks after DBG_8192C deletion Fabio Aiuto
2021-04-10 17:23   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ac547f3a4bd228f372da7057bbfb3cac1535857.1618064274.git.fabioaiuto83@gmail.com \
    --to=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox