From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11F3529A9; Fri, 8 Jul 2022 16:00:28 +0000 (UTC) Received: from [IPV6:2a01:e0a:120:3210:3cab:61a1:2b1f:896b] (unknown [IPv6:2a01:e0a:120:3210:3cab:61a1:2b1f:896b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 76C0B66019F2; Fri, 8 Jul 2022 17:00:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657296027; bh=e0/jiW3XfT4O/Zq416vlwfO7YhtF1rfLZdEy+RlBmfc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TkizvFEqK/XB/KEc40AR6NU3n5lURvLcLZoZFdfZXjSvmZoHM+usmnUXa1V0R2o1M 0OUslPg3PJ8RMh6qGnIaSBNekSI5mjaaLinjBG5ag8sF0/Kcmpq7WS4tdqi7yelo+v SvZTkr5WQv7N64GGlpQiUSuBKblYXLwNh1Cw1JqBtflgPFpBp9xUN5u4sByHvLcMVI ddxL/X974xcXTr9LBm1qoIEK4ah1DiHG3kJN1dAmNHbtpB7pjbDe65w+pGvCaFdlxj zehF4fwRvcvkaMc2R9W46pJNNszISMUzQktns9jVYuDgR3/w3NzX/sZf81GddnVpfn vSbpQSkgA3MQw== Message-ID: <5e346689-5a0c-8fc7-129d-53a6f28e5349@collabora.com> Date: Fri, 8 Jul 2022 18:00:24 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v12 11/17] media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS control Content-Language: en-US To: =?UTF-8?Q?Jernej_=c5=a0krabec?= , mchehab@kernel.org, hverkuil@xs4all.nl, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, samuel@sholland.org, nicolas.dufresne@collabora.com, andrzej.p@collabora.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com References: <20220708120554.495495-1-benjamin.gaignard@collabora.com> <20220708120554.495495-12-benjamin.gaignard@collabora.com> <2106581.irdbgypaU6@jernej-laptop> From: Benjamin Gaignard In-Reply-To: <2106581.irdbgypaU6@jernej-laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 08/07/2022 à 16:02, Jernej Škrabec a écrit : > Hi Benjamin! > > Dne petek, 08. julij 2022 ob 14:05:48 CEST je Benjamin Gaignard napisal(a): >> The number of 'entry point offset' can be very variable. >> Instead of using a large static array define a v4l2 dynamic array >> of U32 (V4L2_CTRL_TYPE_U32). >> The number of entry point offsets is reported by the elems field >> and in struct v4l2_ctrl_hevc_slice_params.num_entry_point_offsets >> field. >> >> Signed-off-by: Benjamin Gaignard >> Acked-by: Nicolas Dufresne >> Tested-by: Jernej Skrabec >> --- >> version 12: >> - Reword num_entry_point_offsets documentation >> >> .../userspace-api/media/v4l/ext-ctrls-codec.rst | 13 +++++++++++++ >> drivers/media/v4l2-core/v4l2-ctrls-defs.c | 5 +++++ >> include/media/hevc-ctrls.h | 5 ++++- >> 3 files changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst index >> c2e0adece613..0cd967126fdf 100644 >> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> @@ -3010,6 +3010,11 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - >> * - __u32 >> - ``data_bit_offset`` >> - Offset (in bits) to the video data in the current slice data. >> + * - __u32 >> + - ``num_entry_point_offsets`` >> + - Specifies the number of entry point offset syntax elements in the >> slice header. + When the driver supports it, the >> ``V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS`` + must be set. >> * - __u8 >> - ``nal_unit_type`` >> - Specifies the coding type of the slice (B, P or I). >> @@ -3150,6 +3155,14 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - >> >> \normalsize >> >> +``V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS (integer)`` >> + Specifies entry point offsets in bytes. >> + This control is a dynamically sized array. The number of entry point >> + offsets is reported by the ``elems`` field. >> + This bitstream parameter is defined according to :ref:`hevc`. >> + They are described in section 7.4.7.1 "General slice segment header >> + semantics" of the specification. > You forgot to update above description per Ezequiel comment. No it was num_entry_point_offsets which was needed to be updated not this control. Regards, Benjamin > > Best regards, > Jernej > >> + >> ``V4L2_CID_STATELESS_HEVC_SCALING_MATRIX (struct)`` >> Specifies the HEVC scaling matrix parameters used for the scaling >> process for transform coefficients. >> diff --git a/drivers/media/v4l2-core/v4l2-ctrls-defs.c >> b/drivers/media/v4l2-core/v4l2-ctrls-defs.c index >> d594efbcbb93..e22921e7ea61 100644 >> --- a/drivers/media/v4l2-core/v4l2-ctrls-defs.c >> +++ b/drivers/media/v4l2-core/v4l2-ctrls-defs.c >> @@ -1188,6 +1188,7 @@ const char *v4l2_ctrl_get_name(u32 id) >> case V4L2_CID_STATELESS_HEVC_DECODE_PARAMS: return > "HEVC Decode >> Parameters"; case V4L2_CID_STATELESS_HEVC_DECODE_MODE: return > "HEVC Decode >> Mode"; case V4L2_CID_STATELESS_HEVC_START_CODE: return > "HEVC Start Code"; >> + case V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS: return > "HEVC Entry >> Point Offsets"; >> >> /* Colorimetry controls */ >> /* Keep the order of the 'case's the same as in v4l2-controls.h! > */ >> @@ -1518,6 +1519,10 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum >> v4l2_ctrl_type *type, case V4L2_CID_STATELESS_HEVC_DECODE_PARAMS: >> *type = V4L2_CTRL_TYPE_HEVC_DECODE_PARAMS; >> break; >> + case V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS: >> + *type = V4L2_CTRL_TYPE_U32; >> + *flags |= V4L2_CTRL_FLAG_DYNAMIC_ARRAY; >> + break; >> case V4L2_CID_STATELESS_VP9_COMPRESSED_HDR: >> *type = V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR; >> break; >> diff --git a/include/media/hevc-ctrls.h b/include/media/hevc-ctrls.h >> index a372c184689e..3a6601a46ced 100644 >> --- a/include/media/hevc-ctrls.h >> +++ b/include/media/hevc-ctrls.h >> @@ -20,6 +20,7 @@ >> #define V4L2_CID_STATELESS_HEVC_DECODE_PARAMS (V4L2_CID_CODEC_BASE > + 1012) >> #define V4L2_CID_STATELESS_HEVC_DECODE_MODE (V4L2_CID_CODEC_BASE + 1015) >> #define V4L2_CID_STATELESS_HEVC_START_CODE (V4L2_CID_CODEC_BASE + 1016) >> +#define V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS (V4L2_CID_CODEC_BASE + >> 1017) >> >> /* enum v4l2_ctrl_type type values */ >> #define V4L2_CTRL_TYPE_HEVC_SPS 0x0120 >> @@ -316,6 +317,8 @@ struct v4l2_hevc_pred_weight_table { >> * >> * @bit_size: size (in bits) of the current slice data >> * @data_bit_offset: offset (in bits) to the video data in the current >> slice data + * @num_entry_point_offsets: specifies the number of entry >> point offset syntax + * elements in the slice > header. >> * @nal_unit_type: specifies the coding type of the slice (B, P or I) >> * @nuh_temporal_id_plus1: minus 1 specifies a temporal identifier for the >> NAL unit * @slice_type: see V4L2_HEVC_SLICE_TYPE_{} >> @@ -358,7 +361,7 @@ struct v4l2_hevc_pred_weight_table { >> struct v4l2_ctrl_hevc_slice_params { >> __u32 bit_size; >> __u32 data_bit_offset; >> - >> + __u32 num_entry_point_offsets; >> /* ISO/IEC 23008-2, ITU-T Rec. H.265: NAL unit header */ >> __u8 nal_unit_type; >> __u8 nuh_temporal_id_plus1; > > >