From: Michael Straube <straube.linux@gmail.com>
To: Deepak R Varma <drv@mailo.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: clean up error handling in rtw_start_drv_threads()
Date: Sun, 6 Nov 2022 16:34:57 +0100 [thread overview]
Message-ID: <5fa89086-c81d-0a3d-8d0d-0bb293052c5c@gmail.com> (raw)
In-Reply-To: <Y2fGGsV5ZwxmkTNB@qemulion>
On 11/6/22 15:35, Deepak R Varma wrote:
> On Sun, Nov 06, 2022 at 02:34:43PM +0100, Michael Straube wrote:
>> Convert the error handling in the function rtw_start_drv_threads() to
>> the common logic used in the kernel. Another step to get rid of _FAIL
>> and _SUCCESS which uses inverted logic.
>
> Hello Michael,
> Can you please tell how did you find this opportunity for improvement? Are you
> using some tool or is it a manual code review/analysis?
>
Hi Deepak,
I just used git grep to search for _FAIL or _SUCCESS and then looked at
the code manually.
Regards,
Michael
next prev parent reply other threads:[~2022-11-06 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 13:34 [PATCH] staging: r8188eu: clean up error handling in rtw_start_drv_threads() Michael Straube
2022-11-06 14:35 ` Deepak R Varma
2022-11-06 15:34 ` Michael Straube [this message]
2022-11-06 15:52 ` Deepak R Varma
2022-11-07 6:22 ` Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fa89086-c81d-0a3d-8d0d-0bb293052c5c@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox