From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dave Penkler <dpenkler@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, marcello.carla@gmx.com
Subject: Re: [PATCH] staging: gpib: Fix lpvo request_system_control
Date: Tue, 22 Apr 2025 09:28:18 +0300 [thread overview]
Message-ID: <60a977f5-5781-48ce-86fb-ea6c4fa767b8@stanley.mountain> (raw)
In-Reply-To: <20250419105254.28359-1-dpenkler@gmail.com>
On Sat, Apr 19, 2025 at 12:52:54PM +0200, Dave Penkler wrote:
> The board should not set the controller-in-charge status in
> request_system_control. It can only become controller-in-charge
> by issuing an interface_clear.
>
> Remove the setting of controller-in-charge from request_system_control.
>
The commit message needs to say what this bug looks like to the user.
regards,
dan carpetner
prev parent reply other threads:[~2025-04-22 6:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 10:52 [PATCH] staging: gpib: Fix lpvo request_system_control Dave Penkler
2025-04-22 6:28 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a977f5-5781-48ce-86fb-ea6c4fa767b8@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcello.carla@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox