From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 852DC6D0D for ; Tue, 6 Apr 2021 16:53:08 +0000 (UTC) Received: by mail-ed1-f43.google.com with SMTP id o19so17428399edc.3 for ; Tue, 06 Apr 2021 09:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SfccbbW2+MpYwGGhGg11TDLfugRMxSMOVQP6jp7h2U8=; b=pQ0ViWyzRs0o24zDGEqtCMMH69JRP424QVOZcXH/CCKrZ97GZiY0ULQcAHxkZ5/WAL yMnt8tDc66eO8JUcJ2MdsAfdurONW1iBpLxuNcXNtW9renL+asEb3f5y72g5N5dES0NF lF75oyb83LxmBGbU55xLsbM49rCpqTQgxnKIjtQ0rJ7iNmp98n10HH3BzzpXbfpucJyb 7zRXWBGN4qjQkNuGKpmoEs9ix3Og3SOh0burWSTX1pMNWqiFPjcebb9wkpeEbjsiV2YS kNb2Fg9AFBvwWmGtAbYktIXCDG0lUP3n4ip4FsXmjHeVfKRCAJYEr2VdOg8bxi0O5hU9 2AaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SfccbbW2+MpYwGGhGg11TDLfugRMxSMOVQP6jp7h2U8=; b=J00ZykmgodvQHElhHi4xT2Kv2hh2p2gXUEhKl/Getssk1zG0FomrMcjrFben7DSBoo AAvmFJsjCZOU8U7gq+RJFoB7Pif1tTxovif53q9hU9tJVnDIHHh2LeMk7vkfVxsglljx ROy21VMTyh+wAGxE7E2GO3r9WXUR1iuUgKJ4b/9FJBvq3WA8zueBcYO2BqVTaoRi+WdY 37+PmMcjELtDrjyKxGyL0qqPlzid71S1xzHCXKyqZo4zZlWKTxY6rt2kLS/p4+xrPl/C 4hHJjRxxjDpMw7UJvf9A28cf4zWosZE7CJEQjX3N4E4mDX5sJVcYcwX0fPF/N6VyZLJq xAbw== X-Gm-Message-State: AOAM530jauPIbumqmhatB9VqVkODMtUCw1QL2vX8ZjZXXwVCNuKT2BG8 hRIvqhmnsoDSGhtFSmsWDHc= X-Google-Smtp-Source: ABdhPJz3CBmGRxoEz52cTS6tYWt/J2du4S9Jag66vzWZ1bn8Cp+BVW37tN+UW+aoR8HGpgjf2ajkfA== X-Received: by 2002:aa7:cb97:: with SMTP id r23mr38335517edt.106.1617727986971; Tue, 06 Apr 2021 09:53:06 -0700 (PDT) Received: from localhost.localdomain (host-79-42-91-147.retail.telecomitalia.it. [79.42.91.147]) by smtp.gmail.com with ESMTPSA id c19sm14255587edu.20.2021.04.06.09.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 09:53:06 -0700 (PDT) From: "Fabio M. De Francesco" To: Julia Lawall Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces around operator in HalBtc8723b1Ant.h Date: Tue, 06 Apr 2021 18:53:05 +0200 Message-ID: <6130008.QCNOj3hcS5@localhost.localdomain> In-Reply-To: References: <20210406164001.13646-1-fmdefrancesco@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="US-ASCII" On Tuesday, April 6, 2021 6:44:00 PM CEST Julia Lawall wrote: > > On Tue, 6 Apr 2021, Fabio M. De Francesco wrote: > > > Added spaces around operators in file HalBtc8723b1Ant.h. Issue detected > > by checkpatch.pl. Spaces are preferred to improve readibility. > > > > Signed-off-by: Fabio M. De Francesco > > --- > > drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h > > index 59e8c68cdc20..719e19420a3b 100644 > > --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h > > +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h > > @@ -15,7 +15,7 @@ > > #define BT_INFO_8723B_1ANT_B_CONNECTION BIT0 > > > > #define BT_INFO_8723B_1ANT_A2DP_BASIC_RATE(_BT_INFO_EXT_) \ > > - (((_BT_INFO_EXT_&BIT0)) ? true : false) > > + (((_BT_INFO_EXT_ & BIT0)) ? true : false) > > There seem to be a lot of parentheses in this code (( )). Maybe you can > make a series and fix that problem too. > > julia OK, good idea. Tomorrow I will also work on this problem. Fabio > > > > > #define BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT 2 > > > > -- > > 2.30.2 > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210406164001.13646-1-fmdefrancesco%40gmail.com. > > >