From: Ira Weiny <ira.weiny@intel.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Kloudifold <cloudifold.3125@gmail.com>,
Alison Schofield <alison.schofield@intel.com>
Cc: <teddy.wang@siliconmotion.com>, <sudipm.mukherjee@gmail.com>,
<gregkh@linuxfoundation.org>, <linux-staging@lists.linux.dev>,
<outreachy@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase
Date: Fri, 17 Mar 2023 22:14:25 -0700 [thread overview]
Message-ID: <641548b142559_28ae5229425@iweiny-mobl.notmuch> (raw)
In-Reply-To: <ZBKDddHeKlWohA0T@debian.me>
Bagas Sanjaya wrote:
> On Wed, Mar 15, 2023 at 11:35:37PM +0800, Kloudifold wrote:
> > Subject: [PATCH v2] staging: sm750: Rename functions from CamelCase to snake case
>
> If I only see the subject above, which functions are renamed? I have
> to see the actual diff if the patch description doesn't answer that.
> In this case, I think the proper subject would be `[PATCH v3] staging:
> sm750: Rename sm750_hw_cursor_* functions to snake_case`.
No. The oneliner is a brief overview.
It is perfectly appropriate to have to look at the diff to see what was
done. The commit message is to state what the problem was and how it was
fixed.
Ira
next prev parent reply other threads:[~2023-03-18 5:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 15:35 [PATCH v2] staging: sm750: Rename function to avoid CamelCase Kloudifold
2023-03-15 15:43 ` Julia Lawall
2023-03-16 2:48 ` Bagas Sanjaya
2023-03-18 5:14 ` Ira Weiny [this message]
2023-03-18 8:50 ` Bagas Sanjaya
-- strict thread matches above, loose matches on Subject: below --
2023-03-13 20:43 Kloudifold
2023-03-13 20:54 ` Julia Lawall
2023-03-14 0:07 ` Philipp Hortmann
2023-03-14 16:04 ` Alison Schofield
2023-03-14 16:39 ` Greg KH
2023-03-14 4:55 ` Bagas Sanjaya
2023-03-14 15:29 ` Alison Schofield
2023-03-15 3:08 ` Bagas Sanjaya
2023-03-15 4:54 ` Greg KH
2023-03-15 8:27 ` Bagas Sanjaya
2023-03-14 15:44 ` Alison Schofield
2023-03-14 15:46 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641548b142559_28ae5229425@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=alison.schofield@intel.com \
--cc=bagasdotme@gmail.com \
--cc=cloudifold.3125@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox