From: Ira Weiny <ira.weiny@intel.com>
To: Khadija Kamran <kamrankhadijadj@gmail.com>, <outreachy@lists.linux.dev>
Cc: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
"Christian Gromm" <christian.gromm@microchip.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: most: fix line ending with '(' in dim2/
Date: Fri, 24 Mar 2023 15:24:27 -0700 [thread overview]
Message-ID: <641e231b9862e_325e1f294e3@iweiny-mobl.notmuch> (raw)
In-Reply-To: <ZByu29jb1mE3KOsn@khadija-virtual-machine>
Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
>
> Move the function parameters right after the '(' in the function call
> line. Align the rest of the parameters to the opening parenthesis.
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>
> Changes in v3:
> - Changed the subject because another patch for 'most/' with the same
> name was causing confusion.
>
> Changes in v2:
> - Changed the description
>
> drivers/staging/most/dim2/hal.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
> index a5d40b5b138a..6abe3ab2b2cf 100644
> --- a/drivers/staging/most/dim2/hal.c
> +++ b/drivers/staging/most/dim2/hal.c
> @@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
> dim2_clear_ctr(ctr_addr);
> }
>
> -static void dim2_configure_channel(
> - u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
> - u16 packet_length)
> +static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
> + u16 hw_buffer_size, u16 packet_length)
Same comment as the previous version I saw.
Ira
> {
> dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
> dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
> --
> 2.34.1
>
>
prev parent reply other threads:[~2023-03-24 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 19:56 [PATCH v3] staging: most: fix line ending with '(' in dim2/ Khadija Kamran
2023-03-24 22:24 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641e231b9862e_325e1f294e3@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=christian.gromm@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox