public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: Khadija Kamran <kamrankhadijadj@gmail.com>, <outreachy@lists.linux.dev>
Cc: <hvaibhav.linux@gmail.com>, <johan@kernel.org>,
	<elder@kernel.org>, <gregkh@linuxfoundation.org>,
	<greybus-dev@lists.linaro.org>, <linux-staging@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] improve arche_platform_wd_irq() function
Date: Sun, 2 Apr 2023 17:36:24 -0700	[thread overview]
Message-ID: <642a1f88bd232_394c38294a5@iweiny-mobl.notmuch> (raw)
In-Reply-To: <cover.1680185025.git.kamrankhadijadj@gmail.com>

Khadija Kamran wrote:
> Improve arche_platform_wd_irq() function to minimize indentation and fix
> checkpatch issues.

Minor point but the cover should have

'staging: greybus: ...'

... for the subject.

The function name is nice but it is a pain to look in the code to know
what part of the kernel this series is for.

Ira

> 
> Khadija Kamran (2):
>   staging: greybus: add a single exit path to arche_platform_wd_irq()
>   staging: greybus: refactor arche_platform_wd_irq()
> 
>  drivers/staging/greybus/arche-platform.c | 84 ++++++++++++------------
>  1 file changed, 43 insertions(+), 41 deletions(-)
> 
> -- 
> 2.34.1
> 
> 



  parent reply	other threads:[~2023-04-03  0:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 14:11 [PATCH 0/2] improve arche_platform_wd_irq() function Khadija Kamran
2023-03-30 14:11 ` [PATCH 1/2] staging: greybus: add a single exit path to arche_platform_wd_irq() Khadija Kamran
2023-04-03  0:37   ` Ira Weiny
2023-04-03  1:21     ` Khadija Kamran
2023-04-03  3:07       ` Alison Schofield
2023-04-03  3:15         ` Alison Schofield
2023-04-03 14:59       ` Ira Weiny
2023-03-30 14:11 ` [PATCH 2/2] staging: greybus: refactor arche_platform_wd_irq() Khadija Kamran
2023-03-30 15:23   ` Dan Carpenter
2023-04-01 17:41     ` Khadija Kamran
2023-04-03  4:29       ` Dan Carpenter
2023-04-03 15:23         ` Dan Carpenter
2023-04-27  6:27         ` Khadija Kamran
2023-05-03 22:16           ` Alison Schofield
2023-04-03  2:18     ` Ira Weiny
2023-03-30 16:58   ` kernel test robot
2023-04-03  0:36 ` Ira Weiny [this message]
2023-04-03  1:18   ` [PATCH 0/2] improve arche_platform_wd_irq() function Khadija Kamran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=642a1f88bd232_394c38294a5@iweiny-mobl.notmuch \
    --to=ira.weiny@intel.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=hvaibhav.linux@gmail.com \
    --cc=johan@kernel.org \
    --cc=kamrankhadijadj@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox