linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: sina hosseinizad <sina.hz@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org,
	sakari.ailus@linux.intel.com, andy@kernel.org,
	gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] media: staging: atomisp: stylefix
Date: Tue, 15 Jul 2025 00:09:33 +0300	[thread overview]
Message-ID: <6519f649-82bd-4f58-b99a-731fb86aa1a6@suswa.mountain> (raw)
In-Reply-To: <20250714142645.88038-1-sina.hz@gmail.com>

On Mon, Jul 14, 2025 at 04:26:45PM +0200, sina hosseinizad wrote:
> change the spaces at the beginning of the line to tabs
> 
> Signed-off-by: sina hosseinizad <sina.hz@gmail.com>

You probably want to capitalize your name.  It's supposed to be written
like you would write it on a legal document.  (These Signed off by lines
are supposed to be like a legal thing which says that you haven't stolen
any code or violated any copy rights in this patch).

> ---
> My first contribution to the linux kernel, so starting out with a stylefix
> ---
>  drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> index bc97fa2c374c..bd3a017490ef 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> @@ -2347,7 +2347,7 @@ int atomisp_css_video_configure_output(struct atomisp_sub_device *asd,
>  }
>  
>  int atomisp_css_video_configure_viewfinder(
> -    struct atomisp_sub_device *asd,
> +	struct atomisp_sub_device *asd,
>      unsigned int width, unsigned int height,

The other lines don't match now.

regards,
dan carpenter

>      unsigned int min_width,
>      enum ia_css_frame_format format)
> -- 
> 2.39.5
> 

      parent reply	other threads:[~2025-07-14 21:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14 14:26 [PATCH] media: staging: atomisp: stylefix sina hosseinizad
2025-07-14 17:53 ` Andy Shevchenko
2025-07-14 21:09 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6519f649-82bd-4f58-b99a-731fb86aa1a6@suswa.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sina.hz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).