* [PATCH] staging: rtl8723bs: remove unused macros from ioctl_linux.c
@ 2021-09-09 21:19 Michael Straube
2021-09-10 6:24 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Michael Straube @ 2021-09-09 21:19 UTC (permalink / raw)
To: gregkh; +Cc: hdegoede, Larry.Finger, linux-staging, linux-kernel,
Michael Straube
These macros are not used in the driver, remove them.
Found with GCC -Wunused-macros.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 908022a17b3f..27fb1be036b8 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -15,20 +15,6 @@
#define RTL_IOCTL_WPA_SUPPLICANT (SIOCIWFIRSTPRIV+30)
-#define SCAN_ITEM_SIZE 768
-#define MAX_CUSTOM_LEN 64
-#define RATE_COUNT 4
-
-/* combo scan */
-#define WEXT_CSCAN_HEADER "CSCAN S\x01\x00\x00S\x00"
-#define WEXT_CSCAN_HEADER_SIZE 12
-#define WEXT_CSCAN_SSID_SECTION 'S'
-#define WEXT_CSCAN_CHANNEL_SECTION 'C'
-#define WEXT_CSCAN_ACTV_DWELL_SECTION 'A'
-#define WEXT_CSCAN_PASV_DWELL_SECTION 'P'
-#define WEXT_CSCAN_HOME_DWELL_SECTION 'H'
-#define WEXT_CSCAN_TYPE_SECTION 'T'
-
static int wpa_set_auth_algs(struct net_device *dev, u32 value)
{
struct adapter *padapter = rtw_netdev_priv(dev);
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: remove unused macros from ioctl_linux.c
2021-09-09 21:19 [PATCH] staging: rtl8723bs: remove unused macros from ioctl_linux.c Michael Straube
@ 2021-09-10 6:24 ` Hans de Goede
2021-09-10 8:12 ` Michael Straube
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2021-09-10 6:24 UTC (permalink / raw)
To: Michael Straube, gregkh; +Cc: Larry.Finger, linux-staging, linux-kernel
Hi,
On 9/9/21 11:19 PM, Michael Straube wrote:
> These macros are not used in the driver, remove them.
> Found with GCC -Wunused-macros.
>
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index 908022a17b3f..27fb1be036b8 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -15,20 +15,6 @@
>
> #define RTL_IOCTL_WPA_SUPPLICANT (SIOCIWFIRSTPRIV+30)
>
> -#define SCAN_ITEM_SIZE 768
> -#define MAX_CUSTOM_LEN 64
> -#define RATE_COUNT 4
> -
> -/* combo scan */
> -#define WEXT_CSCAN_HEADER "CSCAN S\x01\x00\x00S\x00"
> -#define WEXT_CSCAN_HEADER_SIZE 12
> -#define WEXT_CSCAN_SSID_SECTION 'S'
> -#define WEXT_CSCAN_CHANNEL_SECTION 'C'
> -#define WEXT_CSCAN_ACTV_DWELL_SECTION 'A'
> -#define WEXT_CSCAN_PASV_DWELL_SECTION 'P'
> -#define WEXT_CSCAN_HOME_DWELL_SECTION 'H'
> -#define WEXT_CSCAN_TYPE_SECTION 'T'
> -
> static int wpa_set_auth_algs(struct net_device *dev, u32 value)
> {
> struct adapter *padapter = rtw_netdev_priv(dev);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: remove unused macros from ioctl_linux.c
2021-09-10 6:24 ` Hans de Goede
@ 2021-09-10 8:12 ` Michael Straube
0 siblings, 0 replies; 3+ messages in thread
From: Michael Straube @ 2021-09-10 8:12 UTC (permalink / raw)
To: Hans de Goede, gregkh; +Cc: Larry.Finger, linux-staging, linux-kernel
Hi,
On 9/10/21 08:24, Hans de Goede wrote:
> Hi,
>
> On 9/9/21 11:19 PM, Michael Straube wrote:
>> These macros are not used in the driver, remove them.
>> Found with GCC -Wunused-macros.
>>
>> Signed-off-by: Michael Straube <straube.linux@gmail.com>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
Thanks for reviewing.
Regards,
Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-10 8:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-09 21:19 [PATCH] staging: rtl8723bs: remove unused macros from ioctl_linux.c Michael Straube
2021-09-10 6:24 ` Hans de Goede
2021-09-10 8:12 ` Michael Straube
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox