From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47E01143878 for ; Mon, 2 Sep 2024 10:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725271885; cv=none; b=avL04A/0yBnpoXN2ZGq8CrJmLjGpZJrQJplR7mQNHDkdCqGeTAHdk0SS6Rll6c7wRBTuvEozw6BlB62iYlD5rLinajhgYhux3YGwc6mvln0IzpiCGCWlZOerlQTOU9Zz+B2aB9dioYuWHMpInYW0I8GbcrxVlxYvHKC7st7eiTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725271885; c=relaxed/simple; bh=rHSE5GJBbFtpswpn2ChSjpPYB08VFsSB+DaZqumjp5k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DToOuKe5PpZzzo6BwsDz5n0UUqa2H8SPDNFDc4tfY4j2HWDFcxzaznz0/bzOtHOtNXQ6c+LIgxDw25rNe0Q1ZGU5dD/+zvP1rcOjER1DVvVoTxQrKcOTeaincdivOUQV/zw+jSXW/I5jZxMFrNBvUkMypb1s/KCfZGvlrtH8Yn0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=d+7AkZ7M; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d+7AkZ7M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725271883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3uP3eFfEaqOfXTe3+PuBVxVruDu0h3AsswyFqYW83Vo=; b=d+7AkZ7My3h9vfc8uFaZ9gDd714EtuoWTsSszzpycRH3EizNZ//LcXjLmZa7Mt4I1PyDSk xKGDKFjPX8uk0sFNsQxm16NoiDWR9bnpXUMB5AY510rOI+1K2T+BUI/EXOlFBqJdAN/XXU hCRMGXfC902tjZSuku3jYC2TxkXbaeU= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-X0PWZXIUMfKIuLFeKfxSTw-1; Mon, 02 Sep 2024 06:11:22 -0400 X-MC-Unique: X0PWZXIUMfKIuLFeKfxSTw-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-5c254d5e3e3so838137a12.3 for ; Mon, 02 Sep 2024 03:11:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725271881; x=1725876681; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3uP3eFfEaqOfXTe3+PuBVxVruDu0h3AsswyFqYW83Vo=; b=ORqUsjVRJ0ITsDotuTUqw7ERloG3eA2UhTRr4HDHINbN6svuj6b+eib20TcG3IcpT0 w47gjm9zRJvToxczpTYZ9FdBE0nWDOwlzpg6XXrzP5dR5fYIkG4i9Q1oSGA+qxDWxT76 A46067fxUAhijg0sjrCOyWq7XB2/tWbF6uN1xVjaS2EXIQR/IizGyeDm/O4DwFmrcfau hWVUB/p0Q7GmxHlilBsUoleBj4irXCDaPMOD4PUDP4tGkVWJ/mF2fZ/yfox2kzYIHkqQ lWTLtME4JNRKSz3I5RZJSV1P91MA+VrUOWYUVka+cBEjAhSdZvaREC3OvZg/wrUwXevS ZFwA== X-Forwarded-Encrypted: i=1; AJvYcCVaml+zxbxlDXI39/C076ORq28n1fcEfQ+YAZIFe6aHfNvc32PyVKsniinc6mGwvQNH8xrCWNQrs3e4ftyn@lists.linux.dev X-Gm-Message-State: AOJu0Ywe3bKEIgM9Kzt0Lv7mmmZLrl4EIWM3km0yfAc2hGCwkEciTnsQ Cs6dPxqDSjaJCXUV0OOcNL1e54y/obw4TovCGtmsSLbBg3RELdneYnqw4/n2xZJyydgU4ZaWR2+ ffy17MpVRVyHCYOnXraM+AY+YKyYEx1NmE6/uklvOFu82OyDK/ca5I2RhVUqR5V4= X-Received: by 2002:a05:6402:90c:b0:5c0:8ea7:3deb with SMTP id 4fb4d7f45d1cf-5c24236da8bmr4462232a12.22.1725271880832; Mon, 02 Sep 2024 03:11:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTNBBa/kEMoVHxbKZbEtOLcOUPpssqmcz4rwny64KU9r4Q9jmk4fhy7UbqXupII0EuIlzR+A== X-Received: by 2002:a05:6402:90c:b0:5c0:8ea7:3deb with SMTP id 4fb4d7f45d1cf-5c24236da8bmr4462210a12.22.1725271880367; Mon, 02 Sep 2024 03:11:20 -0700 (PDT) Received: from [192.168.171.203] ([109.38.145.100]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c24e5f0aa2sm2286373a12.85.2024.09.02.03.11.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 03:11:19 -0700 (PDT) Message-ID: <65d131fe-952e-45f7-9284-652c23b6abb6@redhat.com> Date: Mon, 2 Sep 2024 12:11:16 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] staging: atomisp: bnr: fix trailing statement To: Kartik Kulkarni , mchehab@kernel.org, akari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: ~lkcamp/patches@lists.sr.ht, helen.koike@collabora.com References: <20240731103353.39245-1-kartik.koolks@gmail.com> From: Hans de Goede In-Reply-To: <20240731103353.39245-1-kartik.koolks@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 7/31/24 12:33 PM, Kartik Kulkarni wrote: > Fix checkpatch error trailing statements should be on next line in > ia_css_bnr.host.c:48 > > Signed-off-by: Kartik Kulkarni Thank you for your patch(es). I have merged this/these in my media-atomisp branch: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp And this/these will be included in my next pull-request to Mauro (to media subsystem maintainer) Regards, Hans > --- > v2: Move Signed-off-by line above the exclusion block > --- > .../atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c > index 457a004e1..b75cfd309 100644 > --- a/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c > +++ b/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c > @@ -45,7 +45,8 @@ ia_css_bnr_dump( > const struct sh_css_isp_bnr_params *bnr, > unsigned int level) > { > - if (!bnr) return; > + if (!bnr) > + return; > ia_css_debug_dtrace(level, "Bayer Noise Reduction:\n"); > ia_css_debug_dtrace(level, "\t%-32s = %d\n", > "bnr_gain_all", bnr->gain_all);