Re: [PATCH v4 1/3] staging: rtl8723bs: Fix space issues

Markus Elfring
2023-07-01T14:43:33Z

You should not put only your own email address into the field “To”.
Please reconsider the distribution of addresses between message header fields once more.

> Fix the following checkpatch space issues:
> - CHECK: spaces preferred around that '*' (ctx:VxV)
> - CHECK: spaces preferred around that '+' (ctx:VxV)
> - CHECK: spaces preferred around that '-' (ctx:VxV)
> - CHECK: spaces preferred around that '|' (ctx:VxV)
> - CHECK: No space is necessary after a cast
> - WARNING: please, no spaces at the start of a line

How good does such a change combination fit to the known requirement
“Solve only one problem per patch.”?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n81

Will it be a bit safer to provide corresponding source code adjustments separately
according to their message types?

…
> v4: Fix sign-off email address
> ---
…

I guess that this misplaced marker line should be deleted at this place
for all update steps in your small patch series.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n686

Regards,
Markus