From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65C7272 for ; Thu, 29 Jul 2021 14:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=c0pAqr7WjXOmFqze5UYuYquQopW+1yGLNu5EKWRUiGc=; b=u07QTVbfnWNQmvKswjiJGLv5mf Q/+cUcRYtTRvAYz8JLJDravtb7cFv1rgmMreNJc+/FZFvZmmmLsCy8hfkY9AAO3GLBZuSDnDB13A0 KeEDjVoqDilEMP7JpmQMz7/24sdJlq8TuUiCNwXZZkIK7W8Dj8YXGTb418+5InGY9owxuPbhJAiyM ODzwpFNN2sfYOH1E4SIvzNsONFVaT4xYZAgmIGR/y/oHIfUXl1WHC9af5JJnMzU3emr2eqQXHnYN3 cgdCThNaqLag18GqTJ9pVFn1C6rFP/VLZCj57ySHNOecjZEqBwJuLyFyuIY/J8r347uVNGXYpiTfQ Aj6sNKOg==; Received: from [2601:1c0:6280:3f0::aefb] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1m97NQ-004biU-Ic; Thu, 29 Jul 2021 14:51:12 +0000 Subject: Re: [PATCH] staging: vt665X: remove unused CONFIG_PATH To: Greg Kroah-Hartman , linux-staging@lists.linux.dev Cc: forest@alittletooquiet.net, linux-kernel@vger.kernel.org, Joe Perches References: <20210729095812.1693061-1-gregkh@linuxfoundation.org> From: Randy Dunlap Message-ID: <68f85669-71a8-b0c9-d23f-0dc7e1de2f12@infradead.org> Date: Thu, 29 Jul 2021 07:51:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210729095812.1693061-1-gregkh@linuxfoundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/29/21 2:58 AM, Greg Kroah-Hartman wrote: > The vt6655 and vt6656 drivers have an unused CONFIG_PATH define floating > around in the code, but it is never used. Remove it as drivers should > never be reading from config files anyway, even if these were valid > files. > > Reported-by: Joe Perches > Reported-by: Randy Dunlap > Signed-off-by: Greg Kroah-Hartman Acked-by: Randy Dunlap Thanks. > --- > drivers/staging/vt6655/device_cfg.h | 3 --- > drivers/staging/vt6656/device.h | 2 -- > 2 files changed, 5 deletions(-) > > diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h > index db0304f6e21c..2d647a3619ba 100644 > --- a/drivers/staging/vt6655/device_cfg.h > +++ b/drivers/staging/vt6655/device_cfg.h > @@ -38,9 +38,6 @@ > > #include > #include > -#ifndef CONFIG_PATH > -#define CONFIG_PATH "/etc/vntconfiguration.dat" > -#endif > > #define PKT_BUF_SZ 2390 > > diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h > index 947530fefe94..2c93a2e66c8a 100644 > --- a/drivers/staging/vt6656/device.h > +++ b/drivers/staging/vt6656/device.h > @@ -77,8 +77,6 @@ > #define FIRMWARE_NAME "vntwusb.fw" > #define FIRMWARE_CHUNK_SIZE 0x400 > > -#define CONFIG_PATH "/etc/vntconfiguration.dat" > - > #define MAX_UINTS 8 > #define OPTION_DEFAULT { [0 ... MAX_UINTS - 1] = -1} > > -- ~Randy