From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Yogesh Hegde <yogi.kernel@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/4] Remove unused rf_set_sens variable
Date: Mon, 24 Apr 2023 20:37:29 +0200 [thread overview]
Message-ID: <695a4474-9a46-a9ee-2ec5-04dbcb68ca0c@gmail.com> (raw)
In-Reply-To: <cover.1682358035.git.yogi.kernel@gmail.com>
On 4/24/23 20:03, Yogesh Hegde wrote:
> The rf_set_sens variable is declared but never set, so it is always NULL.
> Cleanup the unused rf_set_sens variable. Remove functions
> _rtl92e_wx_get_sens and _rtl92e_wx_set_sens which always returned
> error code after removal of rf_set_sens variable.
> Cleanup unused max_sens and sens variable.
> The patches are required to be applied in sequence.
>
> Changes in v5:
> 1. Rebased onto latest staging-testing branch per feedback from
> philipp.g.hortmann@gmail.com
>
> Changes in v4:
> 1. Split changes into patch series per feedback from
> gregkh@linuxfoundation.org
>
> Changes in v3:
> 1. Fixed description to fit within 75 chars
> 2. Added suggested tags
> per feedback from philipp.g.hortmann@gmail.com
>
> Changes in v2:
> 1. Removed function definition rf_set_sens
> 2. Removed usage of variable priv->rf_set_sens
> 3. Removed functions _rtl92e_wx_get_sens and _rtl92e_wx_set_sens
> 4. Cleaned up the variables sens and max_sens used in these functions
>
> Changes in v1:
> 1. Fix comparison to NULL of variable rf_set_sens
>
> Yogesh Hegde (4):
> staging: rtl8192e: Remove unused rf_set_sens variable
> staging: rtl8192e: Remove unused _rtl92e_wx_get_sens function
> staging: rtl8192e: Remove unused _rtl92e_wx_set_sens function
> staging: rtl8192e: Remove unused sens and max_sens from r8192_priv
> struct
>
> drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 45 --------------------
> 2 files changed, 48 deletions(-)
>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
prev parent reply other threads:[~2023-04-24 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 18:03 [PATCH v5 0/4] Remove unused rf_set_sens variable Yogesh Hegde
2023-04-24 18:04 ` [PATCH v5 1/4] staging: rtl8192e: " Yogesh Hegde
2023-04-24 18:04 ` [PATCH v5 2/4] staging: rtl8192e: Remove unused _rtl92e_wx_get_sens function Yogesh Hegde
2023-04-24 18:05 ` [PATCH v5 3/4] staging: rtl8192e: Remove unused _rtl92e_wx_set_sens function^[ Yogesh Hegde
2023-04-24 18:05 ` [PATCH v5 4/4] staging: rtl8192e: Remove unused sens and max_sens from r8192_priv struct Yogesh Hegde
2023-04-24 18:37 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=695a4474-9a46-a9ee-2ec5-04dbcb68ca0c@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=yogi.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox