From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Franziska Näpelt" <franziska.naepelt@googlemail.com>
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
eperi1024@gmail.com, hdegoede@redhat.com,
quic_vjakkam@quicinc.com, johannes.berg@intel.com,
tegongkang@gmail.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 0/3] Fix some checkpatch issues
Date: Thu, 29 Jun 2023 10:40:40 +0300 [thread overview]
Message-ID: <69a90f88-634a-4126-8d33-e770fcc4b686@kadam.mountain> (raw)
In-Reply-To: <CAAUT3iM7eAYH5AcN=Ko9jDstEUGqXxG7Q6qjp4O9qF_e2WkUVQ@mail.gmail.com>
On Wed, Jun 28, 2023 at 06:38:03PM +0200, Franziska Näpelt wrote:
>
> Do you want me to submit v4 to fix the email address as well as the subject of
> the cover letter or are you ok with me promising to make it properly the next
> time? ;)
Philipp is not the person to ask, it's Greg.
Yes, you are going to need to resend because of the email address thing.
Probably the cover letter is not a reason to resend, but since you are
resending then please fix that as well.
The reason why we insist that you resend is a couple things:
1) This is a checkpatch change to staging so we assume that you're just
doing it to learn how patches are supposed to be sent. So this is an
educational opportunity. ;)
2) Greg maintains staging, usb, serial and -stable. He's super busy.
It doesn't scale to hand edit patches. Some maintainers are less
busy so they can fix trivial stuff like this but in staging you will
need to resend. Also if it were a security fix maybe I would step
in and help you fix your patch but since it's just a checkpatch thing
no one is going to edit your patch.
Right now the merge window is open so Greg isn't going to see your patch
for a few weeks. When he does he will press the button on his keyboard
which sends an automatic reply about the email address thing and deletes
the thread from his inbox.
regards,
dan carpenter
next prev parent reply other threads:[~2023-06-29 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 15:56 [PATCH v3 0/3] Fix some checkpatch issues Franziska Naepelt
2023-06-25 15:59 ` [PATCH v3 1/3] staging: rtl8723bs: Fix space issues Franziska Naepelt
2023-06-25 16:00 ` [PATCH v3 2/3] staging: rtl8723bs: Fix alignment open parenthesis Franziska Naepelt
2023-06-25 16:00 ` [PATCH v3 3/3] staging: rtl8723bs: Fix remaining blank line issue Franziska Naepelt
2023-06-25 16:02 ` [PATCH v3 0/3] Fix some checkpatch issues Franziska Näpelt
2023-06-26 17:09 ` Philipp Hortmann
2023-06-28 16:38 ` Franziska Näpelt
2023-06-28 20:17 ` Philipp Hortmann
2023-06-29 7:40 ` Dan Carpenter [this message]
2023-07-01 10:35 ` Franziska Näpelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69a90f88-634a-4126-8d33-e770fcc4b686@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=eperi1024@gmail.com \
--cc=franziska.naepelt@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=quic_vjakkam@quicinc.com \
--cc=tegongkang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox