From: Alexandru Hossu <hossu.alexandru@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: andy@kernel.org, gregkh@linuxfoundation.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: fbtft-bus: replace function-defining macro with concrete functions
Date: Fri, 24 Apr 2026 09:40:48 -0000 [thread overview]
Message-ID: <69eb3b01.5d0a0220.3c3ebd.f35b@mx.google.com> (raw)
In-Reply-To: <aes6JY3Ht6p1VpFa@ashevche-desk.local>
On Fri, Apr 24, 2026 at 12:38:45PM +0300, Andy Shevchenko wrote:
> I'm not sure this patch improves the code. What I see it's harder to follow.
> NAK.
Fair point. Three near-identical functions hide the pattern the macro
makes explicit. I'll drop this approach.
If there's appetite for a minimal fix, I can send a v2 that moves
EXPORT_SYMBOL() outside the macro body only, leaving the function
definition untouched. Otherwise I'll leave it as-is and wait for
Greg's take.
Thanks for the quick review.
Alexandru
next prev parent reply other threads:[~2026-04-24 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 9:28 [PATCH] staging: fbtft: fbtft-bus: replace function-defining macro with concrete functions Alexandru Hossu
2026-04-24 9:38 ` Andy Shevchenko
2026-04-24 9:40 ` Alexandru Hossu [this message]
2026-04-24 9:47 ` Andy Shevchenko
2026-04-24 9:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69eb3b01.5d0a0220.3c3ebd.f35b@mx.google.com \
--to=hossu.alexandru@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox