From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C41E2F25 for ; Thu, 22 Dec 2022 12:05:01 +0000 (UTC) Received: from [IPV6:2401:4900:1f3f:d076:4da6:b729:f032:ed0a] (unknown [IPv6:2401:4900:1f3f:d076:4da6:b729:f032:ed0a]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D1201471; Thu, 22 Dec 2022 13:04:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671710698; bh=o97tTGiyRJiqtRawzNrOFqtwVzXfZ20MOnFXnWX8hhA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bjTfWMggUYqu+kG1g0r+BHK2n4Ys/PUqqer9M+ZWYc7TwbrH/2vlw7RnK7vJy2HJm R3Q3i5rr1JoaO+9jAjn1Quh8To21YsuWEFzUDJb6FlQ0u20K95USQxYrJWaNaFk9d0 bSb/U8+8gVxLqefFkG/zM4GqlRmZ/4NgKSlG7xHc= Message-ID: <6baffa7c-ea7c-aaa6-361a-1a043b065f29@ideasonboard.com> Date: Thu, 22 Dec 2022 17:34:48 +0530 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 5/7] vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect To: Stefan Wahren , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kees Cook , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart References: <20221219115725.11992-1-umang.jain@ideasonboard.com> <20221219115725.11992-6-umang.jain@ideasonboard.com> <8fcbdf54-98ae-6a06-ecaf-591a43b863a1@i2se.com> Content-Language: en-US From: Umang Jain In-Reply-To: <8fcbdf54-98ae-6a06-ecaf-591a43b863a1@i2se.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Stefan, On 12/22/22 4:37 PM, Stefan Wahren wrote: > Hi Umang, > > Am 19.12.22 um 12:57 schrieb Umang Jain: >> Drop the usage of VCHIQ_RETRY when the vchiq has connection status >> VCHIQ_CONNSTATE_DISCONNECTED. Disconnected status will not be valid to >> carry on a retry, replace the VCHIQ_RETRY with -ENOTCONN. >> >> This patch removes the usage of vCHIQ_RETRY completely and act as >> intermediatory to address the TODO item: >>     * Get rid of custom function return values >> for vc04_services/interface. >> >> Fixes: 71bad7f08641 ("staging: add bcm2708 vchiq driver") > please drop this fixes tag since this commit doesn't fix a real issue > and also shouldn't be applied to stable. Should I send a v3 of the series with updated commit message or can you drop the tag while applying? Other option would be to send v2.1  --in-reply-to this patch. I am fine with anything as long as it aligns with the merging workflow. Thanks, Umang >> Signed-off-by: Umang Jain >> --- >>   .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 ++-- >>   1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git >> a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c >> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c >> index 9c64d5de810e..ddb6d0f4daed 100644 >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c >> @@ -3641,7 +3641,7 @@ vchiq_loud_error_footer(void) >>   int vchiq_send_remote_use(struct vchiq_state *state) >>   { >>       if (state->conn_state == VCHIQ_CONNSTATE_DISCONNECTED) >> -        return VCHIQ_RETRY; >> +        return -ENOTCONN; >>         return queue_message(state, NULL, MAKE_REMOTE_USE, NULL, >> NULL, 0, 0); >>   } >> @@ -3649,7 +3649,7 @@ int vchiq_send_remote_use(struct vchiq_state >> *state) >>   int vchiq_send_remote_use_active(struct vchiq_state *state) >>   { >>       if (state->conn_state == VCHIQ_CONNSTATE_DISCONNECTED) >> -        return VCHIQ_RETRY; >> +        return -ENOTCONN; >>         return queue_message(state, NULL, MAKE_REMOTE_USE_ACTIVE, >>                    NULL, NULL, 0, 0);