public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Pavel Skripkin <paskripkin@gmail.com>
To: Ivan Safonov <insafonov@gmail.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michael Straube <straube.linux@gmail.com>,
	"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
	Martin Kaiser <martin@kaiser.cx>,
	Cai Huoqing <cai.huoqing@linux.dev>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] r8188eu: remove unused urbs from struct xmit_buf
Date: Sun, 17 Apr 2022 21:13:09 +0300	[thread overview]
Message-ID: <6c29201d-a717-9ce3-21c0-6c663fc9add3@gmail.com> (raw)
In-Reply-To: <20220417163608.42917-1-insafonov@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 346 bytes --]

Hi Ivan,

On 4/17/22 19:36, Ivan Safonov wrote:
> Driver allocates eighth urbs per xmit_buf, but uses only first urb.
> Allocation of seven remaining urbs wastes memory for nothing.
> 
> Signed-off-by: Ivan Safonov <insafonov@gmail.com>

thanks,

Reviewed-by: Pavel Skripkin <paskripkin@gmail.com>



With regards,
Pavel Skripkin

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

      reply	other threads:[~2022-04-17 18:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-17 16:36 [PATCH] r8188eu: remove unused urbs from struct xmit_buf Ivan Safonov
2022-04-17 18:13 ` Pavel Skripkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c29201d-a717-9ce3-21c0-6c663fc9add3@gmail.com \
    --to=paskripkin@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=cai.huoqing@linux.dev \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox