From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ma Ke <make_ruc2021@163.com>
Cc: mripard@kernel.org, paul.kocialkowski@bootlin.com,
mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] media: cedrus: fix use after free bug in cedrus_remove due to race condition
Date: Fri, 15 Sep 2023 15:33:40 +0300 [thread overview]
Message-ID: <6ccc8fb2-4bd9-4df5-afe2-17868c4023f6@kadam.mountain> (raw)
In-Reply-To: <20230915114038.3407953-1-make_ruc2021@163.com>
No, the code is okay. The works is created in probe() and canceled in
remove(). You've added a new cancel in release() which is the wrong
place. probe() pairs with remove(). open() pairs with release().
regards,
dan carpenter
next prev parent reply other threads:[~2023-09-15 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 11:40 [PATCH] media: cedrus: fix use after free bug in cedrus_remove due to race condition Ma Ke
2023-09-15 12:33 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-08 3:23 Zheng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ccc8fb2-4bd9-4df5-afe2-17868c4023f6@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=make_ruc2021@163.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox