From: Dan Carpenter <dan.carpenter@linaro.org>
To: Gustavo Montenari Pechta <mrpechta@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH] staging: rtl8192e: Fix camel case
Date: Thu, 22 Aug 2024 12:12:25 +0300 [thread overview]
Message-ID: <6fc7a4ef-7a24-451e-8138-6cc4af033fc6@stanley.mountain> (raw)
In-Reply-To: <20240822002733.27609-1-mrpechta@gmail.com>
On Wed, Aug 21, 2024 at 09:27:30PM -0300, Gustavo Montenari Pechta wrote:
> Fix camel case on variable name to match style convention
>
> Signed-off-by: Gustavo Montenari Pechta <mrpechta@gmail.com>
> ---
> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 32 +++++++++----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index 6ef38f4ca17c..14e50acb40b5 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -240,7 +240,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
> const u8 bMac_Tmp_Addr[ETH_ALEN] = {0x00, 0xe0, 0x4c, 0x00, 0x00, 0x01};
> u8 tempval;
> u8 ICVer8192, ICVer8256;
> - u16 i, usValue, IC_Version;
> + u16 i, us_value, IC_Version;
The "us" stands for unsigned short. We don't really want that kind of variable
naming scheme in the kernel. Just call it "value" or think of a better name.
regards,
dan carpenter
prev parent reply other threads:[~2024-08-22 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 0:27 [PATCH] staging: rtl8192e: Fix camel case Gustavo Montenari Pechta
2024-08-22 7:54 ` Greg Kroah-Hartman
2024-08-22 9:12 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fc7a4ef-7a24-451e-8138-6cc4af033fc6@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mrpechta@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox