From: Michael Straube <straube.linux@gmail.com>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
martin@kaiser.cx, fmdefrancesco@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] staging: r8188eu: remove unused fields from struct hal_data_8188e
Date: Wed, 15 Sep 2021 10:56:32 +0200 [thread overview]
Message-ID: <70042ac9-b114-9447-e25a-b5f75496ee63@gmail.com> (raw)
In-Reply-To: <YUEgoipiosdhiXdq@equinox>
On 9/15/21 00:22, Phillip Potter wrote:
> On Tue, Sep 14, 2021 at 02:13:48PM +0200, Michael Straube wrote:
>> This series removes some unused fields from struct hal_data_8188eu.
>>
>> Tested on x86_64 with Inter-Tech DMG-02.
>>
>> Michael Straube (4):
>> staging: r8188eu: remove unused macros from rtl8188e_hal.h
>> staging: r8188eu: remove write-only fields from struct hal_data_8188e
>> staging: r8188eu: remove unused enums from rtl8288e_hal.h
>> staging: r8188eu: remove unused field from struct hal_data_8188e
>>
>> .../staging/r8188eu/hal/rtl8188e_hal_init.c | 5 -----
>> .../staging/r8188eu/include/rtl8188e_hal.h | 22 -------------------
>> 2 files changed, 27 deletions(-)
>>
>> --
>> 2.33.0
>>
>
> Dear Michael,
>
> Looks good, built and tested here and working fine - as you say though
> these are removals of unused code/properties so I was expecting it to
> work anyway :-)
>
> One small thing to change though: the subject line of PATCH 3/4 should
> refer to rtl8188e_hal.h, rather than rtl8288e_hal.h.
Thank you for reviewing and spotting the typo Phillip.
I'll send v2 soon.
Regards,
Michael
prev parent reply other threads:[~2021-09-15 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 12:13 [PATCH 0/4] staging: r8188eu: remove unused fields from struct hal_data_8188e Michael Straube
2021-09-14 12:13 ` [PATCH 1/4] staging: r8188eu: remove unused macros from rtl8188e_hal.h Michael Straube
2021-09-14 12:13 ` [PATCH 2/4] staging: r8188eu: remove write-only fields from struct hal_data_8188e Michael Straube
2021-09-14 12:13 ` [PATCH 3/4] staging: r8188eu: remove unused enums from rtl8288e_hal.h Michael Straube
2021-09-14 12:13 ` [PATCH 4/4] staging: r8188eu: remove unused field from struct hal_data_8188e Michael Straube
2021-09-14 22:22 ` [PATCH 0/4] staging: r8188eu: remove unused fields " Phillip Potter
2021-09-15 8:56 ` Michael Straube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70042ac9-b114-9447-e25a-b5f75496ee63@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox