From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8798E3FC3 for ; Wed, 15 Sep 2021 08:56:35 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id d6so2604711wrc.11 for ; Wed, 15 Sep 2021 01:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=BrOGHGt7cC0oT366jdb+W6ImeT82WbSz/76J3XwKsF8=; b=DL1iZmiMaXVusOOHpuKdsQXBCBI4VyrKd1zr+C9X/hN67XuYWfszjjCoA3b8STPyxf 1KxdC7FY4WyAmNn2Kf7ux5WXthSHcuUHuZSUG2VWIjkXSUgSkTrCO1q/3WDdqEbj+gi+ QDrwhr27v2YE5V+M0dyM5nFMKQqSH+YOWjp7D0WRzBbefmy2kCVI7UEwZfVH2uMbEnhF bqxFUy+bXbM2QChj1UGfWxKdizLLDe41hVkA00PEy80LaokVx/JG18jk7VAC2Jngfsi7 SItcbUMqwoT19jfyHJsWbDBksNxhuN6wzLN+JZc1HVDeXk8nz6ZZIfDHCajMYo2q44GI 0sgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BrOGHGt7cC0oT366jdb+W6ImeT82WbSz/76J3XwKsF8=; b=l7Dthrum1xIlqj6fKT3pX2paGMQmDwRuPEyqwvbpteSBt0IJjathfcI+fK7Tt2F1BC QzYlAC4fdc81KCC6IrNAqRc3S+ZERB+fUntKLKyoQpemJRFwyRXLlLI0xFGoGjAyfq+7 kLR91CHwBbhDHaPpQEqGIpDhtERQ1qPO3m1EPzu95zNeyRAkvGWF8B40czWejbgwiQbW GDej4Kqi2YDwTLCROmvkkQ/zhnM8yk57QD932sNCqjNChk2FEDZoUvbzBOzyhkHo5Lwy /9SeAltQtl4w/NMl4NZTPBUUg8/qochs2oUUpDBrAGdskuoLgGK4kUMtfvRtRcJITuQr qywQ== X-Gm-Message-State: AOAM532FRW6xSKX/N7RnYv0KSMQwh3br7Dc7gysERmv5Z15H4OFQHyQ9 faF0qkNF2lg+uV9msdLa1sA= X-Google-Smtp-Source: ABdhPJxkmtWxZER2bPF5Y8q7uwbsEORrfxEp7wPIBWKWuYwEYaVw+XyWIHZcnzLCAKOrW0+FWYCAvg== X-Received: by 2002:a5d:63d2:: with SMTP id c18mr3613545wrw.311.1631696193795; Wed, 15 Sep 2021 01:56:33 -0700 (PDT) Received: from ?IPV6:2a02:8108:96c0:3b88::1db2? ([2a02:8108:96c0:3b88::1db2]) by smtp.gmail.com with ESMTPSA id u8sm3812049wmq.45.2021.09.15.01.56.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 01:56:33 -0700 (PDT) Message-ID: <70042ac9-b114-9447-e25a-b5f75496ee63@gmail.com> Date: Wed, 15 Sep 2021 10:56:32 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [PATCH 0/4] staging: r8188eu: remove unused fields from struct hal_data_8188e Content-Language: en-US To: Phillip Potter Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210914121352.26052-1-straube.linux@gmail.com> From: Michael Straube In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/15/21 00:22, Phillip Potter wrote: > On Tue, Sep 14, 2021 at 02:13:48PM +0200, Michael Straube wrote: >> This series removes some unused fields from struct hal_data_8188eu. >> >> Tested on x86_64 with Inter-Tech DMG-02. >> >> Michael Straube (4): >> staging: r8188eu: remove unused macros from rtl8188e_hal.h >> staging: r8188eu: remove write-only fields from struct hal_data_8188e >> staging: r8188eu: remove unused enums from rtl8288e_hal.h >> staging: r8188eu: remove unused field from struct hal_data_8188e >> >> .../staging/r8188eu/hal/rtl8188e_hal_init.c | 5 ----- >> .../staging/r8188eu/include/rtl8188e_hal.h | 22 ------------------- >> 2 files changed, 27 deletions(-) >> >> -- >> 2.33.0 >> > > Dear Michael, > > Looks good, built and tested here and working fine - as you say though > these are removals of unused code/properties so I was expecting it to > work anyway :-) > > One small thing to change though: the subject line of PATCH 3/4 should > refer to rtl8188e_hal.h, rather than rtl8288e_hal.h. Thank you for reviewing and spotting the typo Phillip. I'll send v2 soon. Regards, Michael