From: Hans Verkuil <hverkuil@xs4all.nl>
To: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: media: tegra-video: Align line break to match with the open parenthesis in file vi.c
Date: Thu, 15 Apr 2021 16:04:39 +0200 [thread overview]
Message-ID: <72418471-9cd9-e271-e125-3196ff589891@xs4all.nl> (raw)
In-Reply-To: <20210414130939.GA15290@focaruja>
On 14/04/2021 15:09, Aline Santana Cordeiro wrote:
> Align line break to match with the open parenthesis.
> Issue detected by checkpatch.pl.
>
> Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
> ---
> drivers/staging/media/tegra-video/vi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c
> index 7a09061c..9878d1e 100644
> --- a/drivers/staging/media/tegra-video/vi.c
> +++ b/drivers/staging/media/tegra-video/vi.c
> @@ -1813,7 +1813,8 @@ static int tegra_vi_graph_parse_one(struct tegra_vi_channel *chan,
> }
>
> tvge = v4l2_async_notifier_add_fwnode_subdev(&chan->notifier,
> - remote, struct tegra_vi_graph_entity);
> + remote,
Add this line to the previous line. That looks a bit better and is one line
shorter.
Regards,
Hans
> + struct tegra_vi_graph_entity);
> if (IS_ERR(tvge)) {
> ret = PTR_ERR(tvge);
> dev_err(vi->dev,
>
prev parent reply other threads:[~2021-04-15 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 13:09 [PATCH] staging: media: tegra-video: Align line break to match with the open parenthesis in file vi.c Aline Santana Cordeiro
2021-04-15 14:04 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72418471-9cd9-e271-e125-3196ff589891@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=alinesantanacordeiro@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox