Linux kernel staging patches
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Archana <craechal@gmail.com>
Cc: gregkh@linuxfoundation.org, drv@mailo.com, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/2] staging: wlan-ng: small cleanup in writeimage()
Date: Sat, 11 Mar 2023 15:37:13 +0300	[thread overview]
Message-ID: <74e2b862-dca2-42db-8db6-9bd896c13026@kili.mountain> (raw)
In-Reply-To: <20230311121253.10225-1-craechal@gmail.com>

On Sat, Mar 11, 2023 at 12:12:52PM +0000, Archana wrote:
> It is cleaner to use "goto free_result;" as is being followed
> in rest of the implementation of writeimage function, and
> remove unnecessary kfree statements.
> 
> Signed-off-by: Archana <craechal@gmail.com>
> ---
> Changes in v2:
>   - Make the commit message more clearer.

Thanks.  Both look good to me now.

Reviewed-by: Dan Carpenter <error27@gmail.com>

regards,
dan carpenter


  parent reply	other threads:[~2023-03-11 12:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 20:59 [PATCH 1/2] staging: wlan-ng: remove unnecessary kfree statements Archana
2023-03-10 20:59 ` [PATCH 2/2] staging: wlan-ng: remove else statement Archana
2023-03-11  4:34   ` Dan Carpenter
2023-03-11  4:58     ` Dan Carpenter
2023-03-11  7:39       ` Greg KH
2023-03-11 12:12         ` [PATCH v2 1/2] staging: wlan-ng: small cleanup in writeimage() Archana
2023-03-11 12:12           ` [PATCH v2 2/2] staging: wlan-ng: small cleanup in plugimage() Archana
2023-03-11 12:37           ` Dan Carpenter [this message]
2023-03-11 12:45         ` [PATCH 2/2] staging: wlan-ng: remove else statement Archana
2023-03-11  7:40 ` [PATCH 1/2] staging: wlan-ng: remove unnecessary kfree statements Greg KH
2023-03-16 11:19   ` Archana
2023-03-16 11:27   ` Archana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74e2b862-dca2-42db-8db6-9bd896c13026@kili.mountain \
    --to=error27@gmail.com \
    --cc=craechal@gmail.com \
    --cc=drv@mailo.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox