From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>, gregkh@linuxfoundation.org
Cc: phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
Gaurav Pathak <gauravpathak129@gmail.com>
Subject: Re: [PATCH] staging: r8188eu: Fix some endian problems
Date: Fri, 20 Jan 2023 00:31:25 +0100 [thread overview]
Message-ID: <750e22fd-ff90-0005-ce14-85c55824b261@gmail.com> (raw)
In-Reply-To: <20230119191219.12080-1-Larry.Finger@lwfinger.net>
On 1/19/23 20:12, Larry Finger wrote:
> Sparse lists the following warnings:
>
> CHECK drivers/staging/r8188eu/core/rtw_mlme.c
> drivers/staging/r8188eu/core/rtw_mlme.c:1197:49: warning: incorrect type in
> argument 2 (different base types)
> drivers/staging/r8188eu/core/rtw_mlme.c:1197:49: expected restricted
> __le16 [usertype] mstatus_rpt
> drivers/staging/r8188eu/core/rtw_mlme.c:1197:49: got unsigned short
> [assigned] [usertype] media_status_rpt
> drivers/staging/r8188eu/core/rtw_mlme.c:1275:57: warning: incorrect type in
> argument 2 (different base types)
> drivers/staging/r8188eu/core/rtw_mlme.c:1275:57: expected restricted
> __le16 [usertype] mstatus_rpt
> drivers/staging/r8188eu/core/rtw_mlme.c:1275:57: got unsigned short
> [assigned] [usertype] media_status
> CHECK drivers/staging/r8188eu/core/rtw_mlme_ext.c
> drivers/staging/r8188eu/core/rtw_mlme_ext.c:6842:58: warning: incorrect type
> in argument 2 (different base types)
> drivers/staging/r8188eu/core/rtw_mlme_ext.c:6842:58: expected restricted
> __le16 [usertype] mstatus_rpt
> drivers/staging/r8188eu/core/rtw_mlme_ext.c:6842:58: got unsigned short
> [assigned] [usertype] media_status
>
> The second argument of rtl8188e_set_FwMediaStatus_cmd() needs to be in CPU
> order, not little-endian; however, when it uses that value to call
> FillH2CCmd_88E() the parameter must be in little-endian order as that
> value will be sent to the firmware. Note that the conversion from LE to CPU
> order was le16_to_cpu() rather than the correct cpu_to_le16.
>
> The definition of FillH2CCmd_88E() is revised, and the proper conversion
> routine is used.
>
> Note that the original code performed one byte swap on the secong argument
> of FillH2CCmd_88E(), and got the correct answer even though the semantics
> were very wrong.
>
> Signed-off-by: Larry Finger<Larry.Finger@lwfinger.net>
> Reportewd-by: Gaurav Pathak<gauravpathak129@gmail.com>
Checkpatch does not like the "w" in "Reportewd-by:".
Tested on x86_64
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
next prev parent reply other threads:[~2023-01-19 23:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 19:12 [PATCH] staging: r8188eu: Fix some endian problems Larry Finger
2023-01-19 23:31 ` Philipp Hortmann [this message]
2023-01-20 5:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=750e22fd-ff90-0005-ce14-85c55824b261@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gauravpathak129@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox