linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Navaneeth K <knavaneeth786@gmail.com>
To: Abdun Nihaal <abdun.nihaal@gmail.com>
Cc: parthiban.veerasooran@microchip.com,
	christian.gromm@microchip.com, gregkh@linuxfoundation.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] most: usb: remove double cleanup of interface on registration failure
Date: Thu, 27 Nov 2025 03:38:15 +0530	[thread overview]
Message-ID: <75bbd0a9-1e33-4f63-85ed-de1607aa5e2e@gmail.com> (raw)
In-Reply-To: <gavusoqf5ad2xmimbtuuxnp7znm5z57srcqaf3xodenc2wggt5@otqxmfdkogrd>

Hi Nihaal,

Thanks for pointing that out. I missed that Johan's patch was already in 
linux-next.

I will drop this patch and send v3 containing only the core fix (which 
is still needed to prevent the leak).

Regards,
Navaneeth


On 26-11-2025 23:01, Abdun Nihaal wrote:
> On Tue, Nov 25, 2025 at 10:56:06PM +0000, Navaneeth K wrote:
>> Since most_register_interface() now correctly handles cleanup (calling
>> put_device on failure), the manual cleanup in hdm_probe() would cause
>> a double-free.
>>
>> Remove the manual cleanup labels and return the error code directly.
> This exact change has already been done by Johan Hovold in the following
> patch: https://lore.kernel.org/all/20251029093029.28922-1-johan@kernel.org/
>
> I find that patch in Linux-next. It must have been already applied.
> and so you can drop this patch.
>
> Regards,
> Nihaal

      reply	other threads:[~2025-11-26 22:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 22:56 [PATCH v2 0/2] most: core: fix resource leak in most_register_interface error paths Navaneeth K
2025-11-25 22:56 ` [PATCH v2 1/2] " Navaneeth K
2025-11-25 23:10   ` Navaneeth K
2025-11-26 17:23   ` Abdun Nihaal
2025-11-25 22:56 ` [PATCH v2 2/2] most: usb: remove double cleanup of interface on registration failure Navaneeth K
2025-11-26 17:31   ` Abdun Nihaal
2025-11-26 22:08     ` Navaneeth K [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75bbd0a9-1e33-4f63-85ed-de1607aa5e2e@gmail.com \
    --to=knavaneeth786@gmail.com \
    --cc=abdun.nihaal@gmail.com \
    --cc=christian.gromm@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=parthiban.veerasooran@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).