Re: [PATCH v2 1/3] staging: media: Remove duplicate NULL tests on a value in pci

Hans de Goede
2025-04-03T14:19:51Z

Hi,

On 3-Apr-25 3:54 PM, Greg KH wrote:
> On Thu, Apr 03, 2025 at 02:26:41PM +0100, Abraham Samuel Adekunle wrote:
>> When a value has been tested for NULL in an expression, a
>> second NULL test on the same value in another expression
>> is unnecessary when the value has not been assigned NULL.
>>
>> Remove unnecessary duplicate NULL tests on the same value that
>> has previously been NULL tested.
>>
>> Found by Coccinelle
>>
>> Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
>> ---
>> drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 2 +-
>
> I can't take any drivers/staging/media/ changes for outreachy
> applications, sorry. That should have been in the instructions
> somewhere.

I don't know if this helps wrt outreachy but I can pick
up this atomisp (and I plan to do so).

Regards,

Hans