Re: [PATCH v2 2/3] staging: media: Remove duplicated NULL tests on a value in av7110

Andy Shevchenko
2025-04-03T13:37:54Z

On Thu, Apr 03, 2025 at 02:26:42PM +0100, Abraham Samuel Adekunle wrote:
> When a value has been tested for NULL in an expression, a
> second NULL test on the same value in another expression
> is unnecessary when the value has not been assigned NULL.
>
> Remove unnecessary duplicate NULL tests on the same value that
> has previously been NULL tested.
>
> Found by Coccinelle

Missing period. And Subject should be like

"media: sp8870: Remove ..."

When in doubt, run

$ git log --oneline --no-merges -- $YOUR_FILE_OR_FILES

and look at the result. Use common sense and age and frequency of appearance
for possible variants. The more recent and more often wins.

...

Code wise the change looks good now.

--
With Best Regards,
Andy Shevchenko