From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C5887E for ; Mon, 6 Jun 2022 19:01:02 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id y32so24768623lfa.6 for ; Mon, 06 Jun 2022 12:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=HsF6PFNjQdhI9fkMmd1jzJRlQO2RX9NPxQwW7vOOtf8=; b=Sg3b8LiXhFBmypAGCEZfcuogUken/zA0HLogif/U2MAEvxh0B9zlPTD4Up8IMLnbTW TNlcxZXJpZI526Qx0At0s6m4kJ7wuSO/pIeC5VB9IzGP/u59Q0shLPzQEggb6iD9YMkD gmJRb/aV6HKsRED0qmERbpIKux9tgvD8Pktl2OExMHX2NH+TjFzb5Zj5al96PMxFhHBm xrsylH8TuDbfzYsjySWHy5eQ9/qYsHpjrQTVWgU41VXCc+4QGOORStu5qEkrNYwieg5z kNC46PE403d4EOvyhhFsKu8Q9lS6QCuNValXUtMngO4WRyvjU0JWf2uWg+kuz26HOMzN ygDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HsF6PFNjQdhI9fkMmd1jzJRlQO2RX9NPxQwW7vOOtf8=; b=vavLA3xWN0Agaj9HA1t4LmGJe0JES1pYRR4HiOS448dr7jje2LGFIoqEqzwvm/WqaH Zcuz8kJ7bQeU/8TKHDPiDUjniMRJW7cpucRx52cG+wcM/+zz2FpHlVhH+93vqpPuDPLe eAWs8sDcdWlRjfZj6Hs7daAbZWWM7HLkhJe/iDBWQje2bSS5lXLjJhN60xcO1w/twwg5 JOBr/tOYf3vqJMgnuUbIJpuoBljwmW2+M0ARaChreDOSzy48ZaP3N6ahrCIqLNI5lGP3 YFJ1AODjDJ/uGD0+ftG3iK09vTMjAhnQnR3VTMR31CLpWuVJdGE5jrgWt4PrhxSlo6Y0 gEtg== X-Gm-Message-State: AOAM530sUKR7Y/WsCTIXxlsFKKnfHBC7aE1e+PXl7AqnNeCTi2yVMWVe jM8GV667QjZynTSRptS6enU= X-Google-Smtp-Source: ABdhPJyuzwqiwPI3WZiPgTWZqjXJg4VSREuSpZTNo6Em9hBq8mQr6C68Yd5ODYKNHfij3P27ZL1plw== X-Received: by 2002:a05:6512:1293:b0:479:4bbb:f785 with SMTP id u19-20020a056512129300b004794bbbf785mr3950971lfs.170.1654542060100; Mon, 06 Jun 2022 12:01:00 -0700 (PDT) Received: from [192.168.1.11] ([94.103.229.27]) by smtp.gmail.com with ESMTPSA id g28-20020a2eb5dc000000b00253dfbe2522sm2485503ljn.100.2022.06.06.12.00.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jun 2022 12:00:59 -0700 (PDT) Message-ID: <774c3d04-4c02-ed52-f545-73acbffde561@gmail.com> Date: Mon, 6 Jun 2022 22:00:58 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 2/4] staging: r8188eu: add error handling of rtw_read16 Content-Language: en-US To: Greg KH Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, dan.carpenter@oracle.com, fmdefrancesco@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev References: From: Pavel Skripkin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Greg, On 6/6/22 08:48, Greg KH wrote: >> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c >> index e67ecbd1ba79..6662ebc30f7b 100644 >> --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c >> +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c >> @@ -249,11 +249,14 @@ static void efuse_read_phymap_from_txpktbuf( >> hi32 = cpu_to_le32(rtw_read32(adapter, REG_PKTBUF_DBG_DATA_H)); >> >> if (i == 0) { >> + u16 reg; >> + >> /* Although lenc is only used in a debug statement, >> * do not remove it as the rtw_read16() call consumes >> * 2 bytes from the EEPROM source. >> */ >> - rtw_read16(adapter, REG_PKTBUF_DBG_DATA_L); >> + res = rtw_read16(adapter, REG_PKTBUF_DBG_DATA_L, ®); >> + (void)res; > > Same here, that line isn't ok. > hm, that place is not obvious. I guess, on-chip EEPROM acts like a FIFO, so this read must be completed w/o any errors, so I will simply propagate an error to callers And will place another "FIXME" for further work :) thanks, With regards, Pavel Skripkin