public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Chang Yu <marcus.yu.56@gmail.com>
To: Larry.Finger@lwfinger.net
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Chang Yu <marcus.yu.56@gmail.com>
Subject: [PATCH 1/5] staging: r8188eu: Fixed a function declaration coding style issue
Date: Tue, 21 Jun 2022 21:52:30 -0700	[thread overview]
Message-ID: <778c21724752f2de136d82b31c9ffc2bf35ced55.1655872968.git.marcus.yu.56@gmail.com> (raw)
In-Reply-To: <cover.1655872968.git.marcus.yu.56@gmail.com>

Added an identifier name for function definition argument
'struct timer_list *' as per checkpatch.pl

Note that for the same line checkpatch.pl will also complain "extern
should be avoided in .c". I am not very familiar with the codebase
so I decided not to move the declaration to a header file.

Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_recv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
index 36ea79586992..7e2f5c2f9111 100644
--- a/drivers/staging/r8188eu/core/rtw_recv.c
+++ b/drivers/staging/r8188eu/core/rtw_recv.c
@@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] = {
        0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
 };
 
-void rtw_signal_stat_timer_hdl(struct timer_list *);
+void rtw_signal_stat_timer_hdl(struct timer_list *t);
 
 void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
 {
-- 
2.36.1


  reply	other threads:[~2022-06-22  4:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  4:52 [PATCH 0/5] staging: r8188eu: Fixed some coding style issues Chang Yu
2022-06-22  4:52 ` Chang Yu [this message]
2022-06-22  9:32   ` [PATCH 1/5] staging: r8188eu: Fixed a function declaration coding style issue Greg KH
2022-06-22  4:52 ` [PATCH 2/5] staging: r8188eu: Fixed two brace coding style issues Chang Yu
2022-06-22  4:52 ` [PATCH 3/5] staging: r8188eu: Fixed two whitespace " Chang Yu
2022-06-22  4:52 ` [PATCH 4/5] staging: r8188eu: Fixed comment style Chang Yu
2022-06-22  4:52 ` [PATCH 5/5] staging: r8188eu: Fixed some blank line coding style issues Chang Yu
2022-06-22  5:16 ` [PATCH 0/5] staging: r8188eu: Fixed some " Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=778c21724752f2de136d82b31c9ffc2bf35ced55.1655872968.git.marcus.yu.56@gmail.com \
    --to=marcus.yu.56@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox