From: Dan Carpenter <dan.carpenter@linaro.org>
To: Wiktor Grzywacz <wiktor.grzywacz@3mdeb.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Signed-off-by: Wiktor Grzywacz <wiktor.grzywacz@3mdeb.com>
Date: Wed, 25 Oct 2023 14:13:01 +0300 [thread overview]
Message-ID: <793abd56-abaa-4780-a6ae-a5ea2cc2b7bd@kadam.mountain> (raw)
In-Reply-To: <20231025102614.125291-1-wiktor.grzywacz@3mdeb.com>
On Wed, Oct 25, 2023 at 12:24:20PM +0200, Wiktor Grzywacz wrote:
> staging: rtl8723bs: fix checkpatch space before tab warning
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> index 2028791988e7..8bdb685c10e7 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> @@ -46,7 +46,7 @@ static void Init_ODM_ComInfo_8723b(struct adapter *Adapter)
> ODM_CmnInfoInit(pDM_Odm, ODM_CMNINFO_CUT_VER, cut_ver);
>
> ODM_CmnInfoInit(pDM_Odm, ODM_CMNINFO_PATCH_ID, pHalData->CustomerID);
> - /* ODM_CMNINFO_BINHCT_TEST only for MP Team */
> + /* ODM_CMNINFO_BINHCT_TEST only for MP Team */
> ODM_CmnInfoInit(pDM_Odm, ODM_CMNINFO_BWIFI_TEST, Adapter->registrypriv.wifi_spec);
>
> pdmpriv->InitODMFlag = ODM_RF_CALIBRATION|ODM_RF_TX_PWR_TRACK;
> @@ -84,7 +84,7 @@ static void Update_ODM_ComInfo_8723b(struct adapter *Adapter)
> /* Pointer reference */
> /* */
> /* ODM_CMNINFO_MAC_PHY_MODE pHalData->MacPhyMode92D */
> - /* ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_MAC_PHY_MODE,&(pDM_Odm->u8_temp)); */
> + /* ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_MAC_PHY_MODE,&(pDM_Odm->u8_temp)); */
This looks weird now because of the extra space. Also it's dead,
commented out code. Just delete it.
regards,
dan carpenter
prev parent reply other threads:[~2023-10-25 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 10:24 [PATCH] Signed-off-by: Wiktor Grzywacz <wiktor.grzywacz@3mdeb.com> Wiktor Grzywacz
2023-10-25 10:41 ` Greg KH
2023-10-25 11:13 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=793abd56-abaa-4780-a6ae-a5ea2cc2b7bd@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=wiktor.grzywacz@3mdeb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox