From: Pavel Skripkin <paskripkin@gmail.com>
To: Martin Kaiser <lists@kaiser.cx>, Yang Li <yang.lee@linux.alibaba.com>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon
Date: Fri, 1 Jul 2022 22:58:58 +0300 [thread overview]
Message-ID: <7d763251-c761-1260-b03a-cecf8f6f9738@gmail.com> (raw)
In-Reply-To: <20220630115848.hkzavd67cwjubjq4@viti.kaiser.cx>
Hi Martin,
Martin Kaiser <lists@kaiser.cx> says:
> Thus wrote Yang Li (yang.lee@linux.alibaba.com):
>
>> Eliminate the following coccicheck warning:
>> ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>> drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>> diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> index b5f6d41464db..5b0f66573d94 100644
>> --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
>> break;
>> default:
>> return false;
>> - };
>> + }
>
>> do {
>> pwrcfgcmd = pwrseqcmd[aryidx];
>> --
>> 2.20.1.7.g153144c
>
> Thanks for spotting this.
>
> Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
^^^^^^^^^^^^^^^^^^^^^^^^^^
No need to backport code-style warning, so Fixes: is not needed here.
Thanks,
--Pavel Skripkin
next prev parent reply other threads:[~2022-07-01 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 9:09 [PATCH -next] staging: r8188eu: remove unneeded semicolon Yang Li
2022-06-30 11:58 ` Martin Kaiser
2022-07-01 19:58 ` Pavel Skripkin [this message]
2022-07-04 12:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d763251-c761-1260-b03a-cecf8f6f9738@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lists@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox