From: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
To: gregkh@linuxfoundation.org
Cc: outreachy@lists.linux.dev, vireshk@kernel.org, johan@kernel.org,
elder@kernel.org, greybus-dev@lists.linaro.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: add blank line after struct
Date: Sun, 19 Mar 2023 15:20:30 +0200 [thread overview]
Message-ID: <7ec03abe-40e8-c56d-d178-20e57b859d0c@gmail.com> (raw)
In-Reply-To: <20230319114155.42148-1-eng.mennamahmoud.mm@gmail.com>
I am sorry, I resend this patch by mistake. please drop it.
Menna
On ١٩/٣/٢٠٢٣ ١٣:٤١, Menna Mahmoud wrote:
> add blank line after struct for readability as
> reported by checkpatch script
>
> " CHECK: Please use a blank line after function/struct/union/enum
> declarations"
>
> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
> ---
> drivers/staging/greybus/gbphy.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h
> index d4a225b76338..1de510499480 100644
> --- a/drivers/staging/greybus/gbphy.h
> +++ b/drivers/staging/greybus/gbphy.h
> @@ -15,6 +15,7 @@ struct gbphy_device {
> struct list_head list;
> struct device dev;
> };
> +
> #define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
>
> static inline void *gb_gbphy_get_data(struct gbphy_device *gdev)
> @@ -43,6 +44,7 @@ struct gbphy_driver {
>
> struct device_driver driver;
> };
> +
> #define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
>
> int gb_gbphy_register_driver(struct gbphy_driver *driver,
next prev parent reply other threads:[~2023-03-19 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 11:41 [PATCH] staging: greybus: add blank line after struct Menna Mahmoud
2023-03-19 11:41 ` [PATCH] staging: greybus: remove unnecessary blank line Menna Mahmoud
2023-03-19 13:20 ` Menna Mahmoud [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-19 11:08 [PATCH] staging: greybus: add blank line after struct Menna Mahmoud
2023-03-19 11:19 ` Julia Lawall
2023-03-19 11:28 ` Menna Mahmoud
2023-03-19 11:36 ` Julia Lawall
2023-03-19 11:41 ` Menna Mahmoud
2023-03-19 11:46 ` Julia Lawall
2023-03-19 11:52 ` Menna Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ec03abe-40e8-c56d-d178-20e57b859d0c@gmail.com \
--to=eng.mennamahmoud.mm@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox