Linux kernel staging patches
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Manjae Cho <manjae.cho@samsung.com>, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: Improve MAR register definition and usage
Date: Wed, 31 Jul 2024 06:58:40 +0200	[thread overview]
Message-ID: <80076244-4d77-45d9-a721-06664e11477e@gmail.com> (raw)
In-Reply-To: <20240730231046.412876-1-manjae.cho@samsung.com>

On 7/31/24 01:10, Manjae Cho wrote:
> This patch improves the usage of the MAR register by updating the relevant
> macro definitions and ensuring consistent usage across the codebase.
> 
> Signed-off-by: Manjae Cho <manjae.cho@samsung.com>
> ---
> v2: Fix line length
> 
>   drivers/staging/rtl8723bs/include/hal_com_reg.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/hal_com_reg.h b/drivers/staging/rtl8723bs/include/hal_com_reg.h
> index baf326d53a46..93aa391fa749 100644
> --- a/drivers/staging/rtl8723bs/include/hal_com_reg.h
> +++ b/drivers/staging/rtl8723bs/include/hal_com_reg.h
> @@ -151,8 +151,8 @@
>   #define REG_BSSID						0x0618
>   #define REG_MAR							0x0620
>   
> -#define MAR0						REG_MAR		/* Multicast Address Register, Offset 0x0620-0x0623 */
> -#define MAR4						(REG_MAR + 4)	/* Multicast Address Register, Offset 0x0624-0x0627 */
> +#define MAR0		REG_MAR		/* Multicast Address Register, Offset 0x0620-0x0623 */
> +#define MAR4		(REG_MAR + 4)	/* Multicast Address Register, Offset 0x0624-0x0627 */
>   
>   #define REG_MAC_SPEC_SIFS				0x063A
>   /*  20100719 Joseph: Hardware register definition change. (HW datasheet v54) */

Hi Manjae,

this patch cannot be applied because you build it on top of your first 
patch which was not accepted. Please rebase this patch.

Thanks for your support.

Bye Philipp

      reply	other threads:[~2024-07-31  4:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240731004335epcas1p382229e79bdaf3f2d48b0f3faa7414ea6@epcas1p3.samsung.com>
2024-07-30 23:10 ` [PATCH v2] staging: rtl8723bs: Improve MAR register definition and usage Manjae Cho
2024-07-31  4:58   ` Philipp Hortmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80076244-4d77-45d9-a721-06664e11477e@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=manjae.cho@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox