From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0765B2CA6 for ; Tue, 7 Dec 2021 12:48:01 +0000 (UTC) Received: by mail-wr1-f47.google.com with SMTP id u1so29173837wru.13 for ; Tue, 07 Dec 2021 04:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Q2jM7lhHj4MSusyqeI/Jl3r21eXJjVqAqeBJnoEgA4o=; b=D4wwnYV+3tWXq7Dj/JCbdGfsMsH4Fi2ZSGz89eVtC7U7DONy0Xh+Sqllxk2HEYYAAQ 1uGQscqKVLvZkGrDzFIu9cnScV2TIm0msnBfgE3A5bZqlxBoGEQ7Ser4YxiFcEITIbTl TJAZj9Vxt1yJm1NyjmN+s1BbYYJlPnD4GoXi09lqeeVOk7cNTA5bxO1gSID/DhRM2Al3 ZNRrA+lZfW5qJf7BShYK7Vs30OFkPdcc0oxZSOZMF8em96IhEKQa2o/yMW14Wrm9J8XH 7RKd5csdFCWW+V9HwPxZIMYku+mECLJC550v2bwQqFzGKgKC17atI/eB6WbVdwN4R/Yf ervQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Q2jM7lhHj4MSusyqeI/Jl3r21eXJjVqAqeBJnoEgA4o=; b=7QfA8+bM1ns5VjzXvDLrgmv/xky1H5sPVBvJKdxU+MIPSSMTsrCNeSIJgQwxjCT//p 48HVhE+KDIfbfRS2DwCbxuvKAHGvfXGI8N3WdDcD/8gRREnmlWp/XA5RJpAq/9Wa7CTl cPg6ZKH85eO2StSmvdrUlZl1ebu8eXbkaZSoS+/PcQZoQ4+H6E909mlrOC3GMyGg28+H X3++MxXYjft2tFd47/Xhw6ySs4nkkJLE6EB8fWgtWhyn9ngpNnJ1Z83YA1ijnZ0ccPzl /rfFN7o0r+gY+f/Mbv6dL//mj1gaaw2N+m3Imo3A9dE8hWdFlEYI7dEsEJdzHV+C5Z1n XZnQ== X-Gm-Message-State: AOAM530Y22IwtGxM9NBwmeJsj8+aqB8gIuZmb8VmOWazfXC4C7BVpmlG woaLQdNXOEsL6dNgwuuB1Tk= X-Google-Smtp-Source: ABdhPJwjjHsXT0ABkbgCWUYTM4yLZA8swLPC2BhxWUxLAzJ1YsnugbPpYiAPJCTH5tlJ/7I4VRGhkg== X-Received: by 2002:adf:e2c5:: with SMTP id d5mr50598794wrj.338.1638881280385; Tue, 07 Dec 2021 04:48:00 -0800 (PST) Received: from ?IPV6:2a02:8108:96c0:3b88::834c? ([2a02:8108:96c0:3b88::834c]) by smtp.gmail.com with ESMTPSA id w17sm15012672wrp.79.2021.12.07.04.47.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Dec 2021 04:47:59 -0800 (PST) Message-ID: <8365eb19-2a03-d053-cfad-22bd54fc1554@gmail.com> Date: Tue, 7 Dec 2021 13:47:59 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH] staging: r8188eu: convert type of HalData in struct adapter Content-Language: en-US To: Greg KH Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20211206092258.3765-1-straube.linux@gmail.com> From: Michael Straube In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/7/21 11:14, Greg KH wrote: > On Mon, Dec 06, 2021 at 10:22:58AM +0100, Michael Straube wrote: >> adapter->HalData is used in the GET_HAL_DATA macro all across the >> driver code but nobody checks if its allocation in >> rtl188eu_alloc_haldata() was successful or not. >> >> To avoid errors when the allocation fails convert the type of field >> HalData from void pointer to struct hal_data_8188eu. Remove >> GET_HAL_DATA, rtl8188eu_alloc_haldata(), rtl8188e_free_hal_data(). >> >> Signed-off-by: Michael Straube >> --- >> Tested on x86_64 with InterTech DMG-02. > > This doesn't apply to my tree anymore, due to the other changes that > were submitted for this driver. Can you rebase and resend please? > Sure, I'll do. Thanks, Michael