From: Dan Carpenter <dan.carpenter@linaro.org>
To: Meir Elisha <meir6264@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
Ruan Jinjie <ruanjinjie@huawei.com>,
Yang Yingliang <yangyingliang@huawei.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Staging: rtl8723bs: fix else after break warning
Date: Mon, 29 Jan 2024 18:08:36 +0300 [thread overview]
Message-ID: <83d0680c-e057-4fb4-a6ee-ed7e0ba06599@moroto.mountain> (raw)
In-Reply-To: <20240129141856.416532-5-meir6264@Gmail.com>
On Mon, Jan 29, 2024 at 04:18:56PM +0200, Meir Elisha wrote:
> Fix checkpatch warning: else is not generally useful after a break or return
>
> Signed-off-by: Meir Elisha <meir6264@Gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 38 +++++++++--------------
> 1 file changed, 14 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 044483f3d678..efaac84f22b4 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -1540,30 +1540,23 @@ void _rtw_join_timeout_handler(struct timer_list *t)
>
> spin_lock_bh(&pmlmepriv->lock);
>
> - if (rtw_to_roam(adapter) > 0) { /* join timeout caused by roaming */
> + if (rtw_to_roam(adapter) == 0) { /* join timeout caused by roaming */
The comment is wrong now.
regards,
dan carpenter
next prev parent reply other threads:[~2024-01-29 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 14:18 [PATCH 0/4] Staging: rtl8723bs: checkpatch fixes for rtw_mlme.c Meir Elisha
2024-01-29 14:18 ` [PATCH 1/4] Staging: rtl8723bs: Remove unnecessary braces Meir Elisha
2024-01-29 14:18 ` [PATCH 2/4] Staging: rtl8723bs: Remove extra spaces Meir Elisha
2024-01-29 15:05 ` Dan Carpenter
2024-01-29 14:18 ` [PATCH 3/4] Staging: rtl8723bs: Fix block comments warning Meir Elisha
2024-01-29 15:06 ` Dan Carpenter
2024-01-29 14:18 ` [PATCH 4/4] Staging: rtl8723bs: fix else after break warning Meir Elisha
2024-01-29 15:08 ` Dan Carpenter [this message]
2024-01-29 20:04 ` [PATCH 0/4] Staging: rtl8723bs: checkpatch fixes for rtw_mlme.c Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d0680c-e057-4fb4-a6ee-ed7e0ba06599@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=meir6264@gmail.com \
--cc=ruanjinjie@huawei.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox