Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

Sam Ravnborg
2023-06-05T20:24:18Z

Hi Michael.

> >
> >Fixes a bug in the backlight driver and prepares fbdev for making
> >struct fb_info.dev optional.
>
> I only see a rename from fbdev to dev...
>
> Is there missing code?
>
> Would a fixes: be useful?
>
> M
>
> >@@ -35,7 +35,7 @@ static int gpio_backlight_check_fb(struct
> >backlight_device *bl,
> > {
> > struct gpio_backlight *gbl = bl_get_data(bl);
> >
> >- return gbl->fbdev == NULL || gbl->fbdev == info->dev;
> >+ return !gbl->dev || gbl->dev == info->device;
> > }

The real change is here where info->dev is replaced by info->device.

Sam