Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Thomas Zimmermann
2023-06-09T11:04:45Z

[-- Attachment #1.1: Type: text/plain, Size: 1464 bytes --]

Hi

Am 09.06.23 um 11:14 schrieb Geert Uytterhoeven:
[...]
>
>>> What do you think low-end embedded devices with an out-of-tree[*]
>>> fbdev driver are using?
>>
>> And those do not count either. IIRC Android used to be built on top of
>> fbdev devices. I'm not sure if they have moved to DRM by now. But
>> embedded uses dedicated kernels and kernel configs. It's easy for them
>> to set FB_DEVICE=y. We're not going to take away the fbdev device entirely.
>
> The point is that we do not suddenly disable functionality that users
> may depend on. While "make oldconfig" will show users the new
> FB_DEVICE question, (and hopefully they'll notice), "make olddefconfig"
> and "make <foo>_defconfig" won't, possibly causing regressions.
> Without a suitable default, you should IMHO at least update all
> defconfigs that enable any fbdev drivers.

Didn't I already say that we should make it "default y" if that's
preferable in practice?

Best regards
Thomas

>
> I guess you do remember the fall-out from f611b1e7624ccdbd ("drm:
> Avoid circular dependencies for CONFIG_FB"), after which lots of defconfigs
> had to gain CONFIG_FB=y?
>
> Gr{oetje,eeting}s,
>
> Geert
>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]