RE: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

Ruhl, Michael J
2023-06-05T20:41:27Z

>-----Original Message-----
>From: Sam Ravnborg <sam@ravnborg.org>
>Sent: Monday, June 5, 2023 4:23 PM
>To: Ruhl, Michael J <michael.j.ruhl@intel.com>
>Cc: Thomas Zimmermann <tzimmermann@suse.de>; daniel@ffwll.ch;
>javierm@redhat.com; deller@gmx.de; geert+renesas@glider.be;
>lee@kernel.org; daniel.thompson@linaro.org; jingoohan1@gmail.com; linux-
>fbdev@vger.kernel.org; Rich Felker <dalias@libc.org>; linux-
>sh@vger.kernel.org; linux-staging@lists.linux.dev; dri-
>devel@lists.freedesktop.org; John Paul Adrian Glaubitz <glaubitz@physik.fu-
>berlin.de>; linux-omap@vger.kernel.org
>Subject: Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct
>fb_info.device
>
>Hi Michael.
>
>> >
>> >Fixes a bug in the backlight driver and prepares fbdev for making
>> >struct fb_info.dev optional.
>>
>> I only see a rename from fbdev to dev...
>>
>> Is there missing code?
>>
>> Would a fixes: be useful?
>>
>> M
>>
>> >@@ -35,7 +35,7 @@ static int gpio_backlight_check_fb(struct
>> >backlight_device *bl,
>> > {
>> > struct gpio_backlight *gbl = bl_get_data(bl);
>> >
>> >- return gbl->fbdev == NULL || gbl->fbdev == info->dev;
>> >+ return !gbl->dev || gbl->dev == info->device;
>> > }
>
>The real change is here where info->dev is replaced by info->device.

Yeah, after a few patches, I was getting the idea that the name was the bug. 😊

Thanks,

M

> Sam