Re: [PATCH v2 3/5] treewide: Replace 0-element memcpy() destinations with flexible arrays

Keith Packard
2021-08-26T05:32:38Z

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

Kees Cook <keescook@chromium.org> writes:

> In some cases, use of the flex_array() helper is needed when a flexible
> array is part of a union.

The code below seems to show that the helper is also needed when the
flexible array is the only member of a struct? Or is this just an
extension of the 'part of a union' clause?

> @@ -160,7 +160,7 @@ struct bmi_cmd {
>
> union bmi_resp {
> struct {
> - u8 payload[0];
> + DECLARE_FLEX_ARRAY(u8, payload);
> } read_mem;
> struct {
> __le32 result;

--
-keith

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]