[PATCH 0/3 v2] staging: rtl8192e: renamed a variable

[PATCH 0/3 v2] staging: rtl8192e: renamed a variable

[Gary Rookard]

Hi!,

This patch series renames the same mixed case variable in (3) different
files of staging/rtl8192e.
1) rtllib.h
2) rtl819x_HTProc.c
3) rtllib_module.c

Regards,
-Gary Rookard <garyrookard@fastmail.org>


-- 
2.41.0

[PATCH 1/3 v2] staging: rtl8192e: rtllib: renamed a prototype variable

[Gary Rookard]

This patch renames a prototype variable from being of mixed case.
HTUpdateDefaultSetting -> ht_update_default_setting

Linux Kernel Coding Style "cleanup", no "runtime" change,
drivers/staging/rtl8192e builds/compiles before and after.

Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
 drivers/staging/rtl8192e/rtllib.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 5517b9df65be..1a3dd4dcad81 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1807,7 +1807,7 @@ int rtllib_wx_get_rts(struct rtllib_device *ieee, struct iw_request_info *info,
 void HTSetConnectBwMode(struct rtllib_device *ieee,
 			enum ht_channel_width bandwidth,
 			enum ht_extchnl_offset Offset);
-void HTUpdateDefaultSetting(struct rtllib_device *ieee);
+void ht_update_default_setting(struct rtllib_device *ieee);
 void HTConstructCapabilityElement(struct rtllib_device *ieee,
 				  u8 *posHTCap, u8 *len,
 				  u8 isEncrypt, bool bAssoc);
-- 
2.41.0

[PATCH 2/3 v2] staging: rtl8192e: rtl819x_HTProc: renamed a function variable

[Gary Rookard]

This patch renames a function variable from being of mixed case,
HTUpdateDetaultSetting -> ht_update_default_setting.

Linux Kernel Coding Style "cleanup", no "runtime" change,
drivers/staging/rtl8192e builds/compiles before and after.

Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index f19feea46158..630acfaf6d55 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -67,7 +67,7 @@ static u8 CISCO_BROADCOM[3] = {0x00, 0x17, 0x94};
 
 static u8 LINKSYS_MARVELL_4400N[3] = {0x00, 0x14, 0xa4};
 
-void HTUpdateDefaultSetting(struct rtllib_device *ieee)
+void ht_update_default_setting(struct rtllib_device *ieee)
 {
 	struct rt_hi_throughput *ht_info = ieee->ht_info;
 
-- 
2.41.0

[PATCH 3/3 v2] staging: rtl8192e: rtllib_module: renamed a referenced variable

[Gary Rookard]

This patch renames a referenced variable from being of mixed case,
HTUpdateDefaultSetting -> ht_update_default_setting.

Linux Kernel Coding Style "cleanup", no runtime change,
drivers/staging/rtl8192e builds/compiles before and after.

Signed-off-by: Gary Rookard <garyrookard@fastmail.org>

---
 drivers/staging/rtl8192e/rtllib_module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging/rtl8192e/rtllib_module.c
index 2416e0c60255..fc0cc4657fee 100644
--- a/drivers/staging/rtl8192e/rtllib_module.c
+++ b/drivers/staging/rtl8192e/rtllib_module.c
@@ -126,7 +126,7 @@ struct net_device *alloc_rtllib(int sizeof_priv)
 	if (!ieee->ht_info)
 		goto free_softmac;
 
-	HTUpdateDefaultSetting(ieee);
+	ht_update_default_setting(ieee);
 	HTInitializeHTInfo(ieee);
 	TSInitialize(ieee);
 	for (i = 0; i < IEEE_IBSS_MAC_HASH_SIZE; i++)
-- 
2.41.0

Re: [PATCH 0/3 v2] staging: rtl8192e: renamed a variable

[Greg KH]

On Wed, Sep 27, 2023 at 07:26:32AM -0400, Gary Rookard wrote:
> Hi!,
> 
> This patch series renames the same mixed case variable in (3) different
> files of staging/rtl8192e.
> 1) rtllib.h
> 2) rtl819x_HTProc.c
> 3) rtllib_module.c
> 
> Regards,
> -Gary Rookard <garyrookard@fastmail.org>
> 
> 
> -- 
> 2.41.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH 0/3 v2] staging: rtl8192e: renamed a variable

[Dan Carpenter]

On Wed, Sep 27, 2023 at 07:26:32AM -0400, Gary Rookard wrote:
> Hi!,
> 
> This patch series renames the same mixed case variable in (3) different
> files of staging/rtl8192e.
> 1) rtllib.h
> 2) rtl819x_HTProc.c
> 3) rtllib_module.c
> 

You need to do this all in one patch, otherwise the kernel can't compile
if we only apply 1 or just 1 and 2.

regards,
dan carpenter

Re: [PATCH 0/3 v2] staging: rtl8192e: renamed a variable

[garyrookard]

Can do, have one already done that way...
Dan Carpenter <dan.carpenter@linaro.org> writes:

> On Wed, Sep 27, 2023 at 07:26:32AM -0400, Gary Rookard wrote:
>> Hi!,
>> 
>> This patch series renames the same mixed case variable in (3) different
>> files of staging/rtl8192e.
>> 1) rtllib.h
>> 2) rtl819x_HTProc.c
>> 3) rtllib_module.c
>> 
>
> You need to do this all in one patch, otherwise the kernel can't compile
> if we only apply 1 or just 1 and 2.
>
> regards,
> dan carpenter

Re: [PATCH 0/3 v2] staging: rtl8192e: renamed a variable

[garyrookard]

Okay, already have one done that way.
Dan Carpenter <dan.carpenter@linaro.org> writes:

> On Wed, Sep 27, 2023 at 07:26:32AM -0400, Gary Rookard wrote:
>> Hi!,
>> 
>> This patch series renames the same mixed case variable in (3) different
>> files of staging/rtl8192e.
>> 1) rtllib.h
>> 2) rtl819x_HTProc.c
>> 3) rtllib_module.c
>> 
>
> You need to do this all in one patch, otherwise the kernel can't compile
> if we only apply 1 or just 1 and 2.
>
> regards,
> dan carpenter