From: garyrookard@fastmail.org
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] rtl8192e: renamed (1) mixed case variable
Date: Tue, 26 Sep 2023 08:38:28 -0400 [thread overview]
Message-ID: <87wmwdw1ls.fsf@fastmail.org> (raw)
In-Reply-To: <2023092617-skydiver-unsworn-18f8@gregkh>
Okay, will do.
Greg KH <gregkh@linuxfoundation.org> writes:
> On Mon, Sep 25, 2023 at 11:11:55AM -0400, Gary Rookard wrote:
>> Renamed (1) prototype variable that was written in mixed case.
>> HTUpdateDefaultSetting -> ht_update_default_setting
>>
>> Linux kernel coding style "cleanup".
>> No change in runtime logic.
>>
>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>> ---
>> drivers/staging/rtl8192e/rtllib.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
>> index 5517b9df65be..1a3dd4dcad81 100644
>> --- a/drivers/staging/rtl8192e/rtllib.h
>> +++ b/drivers/staging/rtl8192e/rtllib.h
>> @@ -1807,7 +1807,7 @@ int rtllib_wx_get_rts(struct rtllib_device *ieee, struct iw_request_info *info,
>> void HTSetConnectBwMode(struct rtllib_device *ieee,
>> enum ht_channel_width bandwidth,
>> enum ht_extchnl_offset Offset);
>> -void HTUpdateDefaultSetting(struct rtllib_device *ieee);
>> +void ht_update_default_setting(struct rtllib_device *ieee);
>> void HTConstructCapabilityElement(struct rtllib_device *ieee,
>> u8 *posHTCap, u8 *len,
>> u8 isEncrypt, bool bAssoc);
>> --
>> 2.41.0
>>
>>
>
> You just broke the build?
>
> Also, you sent 3 patches that do different things, yet have identical
> subject lines, that's obviously not correct.
>
> Please fix up and resend a v2 series.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-09-26 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 15:11 [PATCH 0/3] rtl8192e: renamed (1) mixed case variable Gary Rookard
2023-09-25 15:11 ` [PATCH 1/3] " Gary Rookard
2023-09-26 9:09 ` Greg KH
2023-09-26 12:38 ` garyrookard [this message]
2023-09-25 15:11 ` [PATCH 2/3] " Gary Rookard
2023-09-25 15:11 ` [PATCH 3/3] " Gary Rookard
2023-09-25 17:00 ` [PATCH 0/3] " Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmwdw1ls.fsf@fastmail.org \
--to=garyrookard@fastmail.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).