* [PATCH 1/3] rtl8192e: renamed (1) mixed case variable
2023-09-25 15:11 [PATCH 0/3] rtl8192e: renamed (1) mixed case variable Gary Rookard
@ 2023-09-25 15:11 ` Gary Rookard
2023-09-26 9:09 ` Greg KH
2023-09-25 15:11 ` [PATCH 2/3] " Gary Rookard
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Gary Rookard @ 2023-09-25 15:11 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Gary Rookard
Renamed (1) prototype variable that was written in mixed case.
HTUpdateDefaultSetting -> ht_update_default_setting
Linux kernel coding style "cleanup".
No change in runtime logic.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtllib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 5517b9df65be..1a3dd4dcad81 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1807,7 +1807,7 @@ int rtllib_wx_get_rts(struct rtllib_device *ieee, struct iw_request_info *info,
void HTSetConnectBwMode(struct rtllib_device *ieee,
enum ht_channel_width bandwidth,
enum ht_extchnl_offset Offset);
-void HTUpdateDefaultSetting(struct rtllib_device *ieee);
+void ht_update_default_setting(struct rtllib_device *ieee);
void HTConstructCapabilityElement(struct rtllib_device *ieee,
u8 *posHTCap, u8 *len,
u8 isEncrypt, bool bAssoc);
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] rtl8192e: renamed (1) mixed case variable
2023-09-25 15:11 ` [PATCH 1/3] " Gary Rookard
@ 2023-09-26 9:09 ` Greg KH
2023-09-26 12:38 ` garyrookard
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2023-09-26 9:09 UTC (permalink / raw)
To: Gary Rookard; +Cc: linux-staging, linux-kernel
On Mon, Sep 25, 2023 at 11:11:55AM -0400, Gary Rookard wrote:
> Renamed (1) prototype variable that was written in mixed case.
> HTUpdateDefaultSetting -> ht_update_default_setting
>
> Linux kernel coding style "cleanup".
> No change in runtime logic.
>
> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
> ---
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 5517b9df65be..1a3dd4dcad81 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -1807,7 +1807,7 @@ int rtllib_wx_get_rts(struct rtllib_device *ieee, struct iw_request_info *info,
> void HTSetConnectBwMode(struct rtllib_device *ieee,
> enum ht_channel_width bandwidth,
> enum ht_extchnl_offset Offset);
> -void HTUpdateDefaultSetting(struct rtllib_device *ieee);
> +void ht_update_default_setting(struct rtllib_device *ieee);
> void HTConstructCapabilityElement(struct rtllib_device *ieee,
> u8 *posHTCap, u8 *len,
> u8 isEncrypt, bool bAssoc);
> --
> 2.41.0
>
>
You just broke the build?
Also, you sent 3 patches that do different things, yet have identical
subject lines, that's obviously not correct.
Please fix up and resend a v2 series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] rtl8192e: renamed (1) mixed case variable
2023-09-26 9:09 ` Greg KH
@ 2023-09-26 12:38 ` garyrookard
0 siblings, 0 replies; 7+ messages in thread
From: garyrookard @ 2023-09-26 12:38 UTC (permalink / raw)
To: Greg KH; +Cc: linux-staging, linux-kernel
Okay, will do.
Greg KH <gregkh@linuxfoundation.org> writes:
> On Mon, Sep 25, 2023 at 11:11:55AM -0400, Gary Rookard wrote:
>> Renamed (1) prototype variable that was written in mixed case.
>> HTUpdateDefaultSetting -> ht_update_default_setting
>>
>> Linux kernel coding style "cleanup".
>> No change in runtime logic.
>>
>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>> ---
>> drivers/staging/rtl8192e/rtllib.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
>> index 5517b9df65be..1a3dd4dcad81 100644
>> --- a/drivers/staging/rtl8192e/rtllib.h
>> +++ b/drivers/staging/rtl8192e/rtllib.h
>> @@ -1807,7 +1807,7 @@ int rtllib_wx_get_rts(struct rtllib_device *ieee, struct iw_request_info *info,
>> void HTSetConnectBwMode(struct rtllib_device *ieee,
>> enum ht_channel_width bandwidth,
>> enum ht_extchnl_offset Offset);
>> -void HTUpdateDefaultSetting(struct rtllib_device *ieee);
>> +void ht_update_default_setting(struct rtllib_device *ieee);
>> void HTConstructCapabilityElement(struct rtllib_device *ieee,
>> u8 *posHTCap, u8 *len,
>> u8 isEncrypt, bool bAssoc);
>> --
>> 2.41.0
>>
>>
>
> You just broke the build?
>
> Also, you sent 3 patches that do different things, yet have identical
> subject lines, that's obviously not correct.
>
> Please fix up and resend a v2 series.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] rtl8192e: renamed (1) mixed case variable
2023-09-25 15:11 [PATCH 0/3] rtl8192e: renamed (1) mixed case variable Gary Rookard
2023-09-25 15:11 ` [PATCH 1/3] " Gary Rookard
@ 2023-09-25 15:11 ` Gary Rookard
2023-09-25 15:11 ` [PATCH 3/3] " Gary Rookard
2023-09-25 17:00 ` [PATCH 0/3] " Philipp Hortmann
3 siblings, 0 replies; 7+ messages in thread
From: Gary Rookard @ 2023-09-25 15:11 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Gary Rookard
Renamed (1) function variable that was written in mixed case
HTUpdateDefaultSetting -> ht_update_default_setting
Linux kernel coding style "cleanup".
No change in runtime logic.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index f19feea46158..630acfaf6d55 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -67,7 +67,7 @@ static u8 CISCO_BROADCOM[3] = {0x00, 0x17, 0x94};
static u8 LINKSYS_MARVELL_4400N[3] = {0x00, 0x14, 0xa4};
-void HTUpdateDefaultSetting(struct rtllib_device *ieee)
+void ht_update_default_setting(struct rtllib_device *ieee)
{
struct rt_hi_throughput *ht_info = ieee->ht_info;
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/3] rtl8192e: renamed (1) mixed case variable
2023-09-25 15:11 [PATCH 0/3] rtl8192e: renamed (1) mixed case variable Gary Rookard
2023-09-25 15:11 ` [PATCH 1/3] " Gary Rookard
2023-09-25 15:11 ` [PATCH 2/3] " Gary Rookard
@ 2023-09-25 15:11 ` Gary Rookard
2023-09-25 17:00 ` [PATCH 0/3] " Philipp Hortmann
3 siblings, 0 replies; 7+ messages in thread
From: Gary Rookard @ 2023-09-25 15:11 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Gary Rookard
Renamed (1) referenced variable that was written in mixed case.
HTUpdateDefaultSetting -> ht_update_default_setting
Linux kernel coding style "cleanup".
No change in runtime logic.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtllib_module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging/rtl8192e/rtllib_module.c
index 2416e0c60255..fc0cc4657fee 100644
--- a/drivers/staging/rtl8192e/rtllib_module.c
+++ b/drivers/staging/rtl8192e/rtllib_module.c
@@ -126,7 +126,7 @@ struct net_device *alloc_rtllib(int sizeof_priv)
if (!ieee->ht_info)
goto free_softmac;
- HTUpdateDefaultSetting(ieee);
+ ht_update_default_setting(ieee);
HTInitializeHTInfo(ieee);
TSInitialize(ieee);
for (i = 0; i < IEEE_IBSS_MAC_HASH_SIZE; i++)
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] rtl8192e: renamed (1) mixed case variable
2023-09-25 15:11 [PATCH 0/3] rtl8192e: renamed (1) mixed case variable Gary Rookard
` (2 preceding siblings ...)
2023-09-25 15:11 ` [PATCH 3/3] " Gary Rookard
@ 2023-09-25 17:00 ` Philipp Hortmann
3 siblings, 0 replies; 7+ messages in thread
From: Philipp Hortmann @ 2023-09-25 17:00 UTC (permalink / raw)
To: Gary Rookard, gregkh; +Cc: linux-staging, linux-kernel
On 9/25/23 17:11, Gary Rookard wrote:
> Hi!
>
> This patch set of (3) addresses the correction of mixed case useage
> in (3) driver/staging/rtl8192e files.
> 1/3) rtllib.h
> 2/3) rtl819x_HTProc.c
> 3/3) rtllib_module.c
>
> Variable renamed: HTUpdateDefaultSetting -> ht_update_default_setting
>
> Linux kernel coding style "cleanup", no change in runtime logic,
> compiles with no errors or warnings.
Hi Gary,
you need one patch to change all three usages of the variable.
You need to be able to compile the driver after each patch.
For the next patch you send to the mailing list you need a version
history of your patch.
If you like you can send the patch first only to me. In case of
questions feel free to ask.
Bye Philipp
^ permalink raw reply [flat|nested] 7+ messages in thread