From: Michael Straube <straube.linux@gmail.com>
To: Martin Kaiser <martin@kaiser.cx>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] staging: r8188eu: clean up Hal8188EPhyCfg.h
Date: Sun, 17 Oct 2021 13:54:25 +0200 [thread overview]
Message-ID: <88147425-3137-53d9-3cba-2c52d8ac1556@gmail.com> (raw)
In-Reply-To: <20211016113008.27549-7-martin@kaiser.cx>
On 10/16/21 13:30, Martin Kaiser wrote:
> Remove a bunch of unused structs, enums and defines
> from Hal8188EPhyCfg.h.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> .../staging/r8188eu/include/Hal8188EPhyCfg.h | 59 -------------------
> 1 file changed, 59 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h b/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h
> index feae0b32cac6..58377edf724d 100644
> --- a/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h
> +++ b/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h
> @@ -21,23 +21,6 @@
> /*--------------------------Define Parameters-------------------------------*/
>
> /*------------------------------Define structure----------------------------*/
> -enum sw_chnl_cmd_id {
> - CmdID_End,
> - CmdID_SetTxPowerLevel,
> - CmdID_BBRegWrite10,
> - CmdID_WritePortUlong,
> - CmdID_WritePortUshort,
> - CmdID_WritePortUchar,
> - CmdID_RF_WriteReg,
> -};
> -
> -/* 1. Switch channel related */
> -struct sw_chnl_cmd {
> - enum sw_chnl_cmd_id CmdID;
> - u32 Para1;
> - u32 Para2;
> - u32 msDelay;
> -};
>
> enum hw90_block {
> HW90_BLOCK_MAC = 0,
> @@ -73,16 +56,6 @@ enum wireless_mode {
> WIRELESS_MODE_N_24G = BIT(3),
> };
>
> -enum phy_rate_tx_offset_area {
> - RA_OFFSET_LEGACY_OFDM1,
> - RA_OFFSET_LEGACY_OFDM2,
> - RA_OFFSET_HT_OFDM1,
> - RA_OFFSET_HT_OFDM2,
> - RA_OFFSET_HT_OFDM3,
> - RA_OFFSET_HT_OFDM4,
> - RA_OFFSET_HT_CCK,
> -};
> -
> /* BB/RF related */
> enum RF_TYPE_8190P {
> RF_TYPE_MIN, /* 0 */
> @@ -141,24 +114,6 @@ struct bb_reg_def {
> * Path A and B */
> };
>
> -struct ant_sel_ofdm {
> - u32 r_tx_antenna:4;
> - u32 r_ant_l:4;
> - u32 r_ant_non_ht:4;
> - u32 r_ant_ht1:4;
> - u32 r_ant_ht2:4;
> - u32 r_ant_ht_s1:4;
> - u32 r_ant_non_ht_s1:4;
> - u32 OFDM_TXSC:2;
> - u32 reserved:2;
> -};
> -
> -struct ant_sel_cck {
> - u8 r_cckrx_enable_2:2;
> - u8 r_cckrx_enable:2;
> - u8 r_ccktx_enable:4;
> -};
> -
> /*------------------------------Define structure----------------------------*/
>
> /*------------------------Export global variable----------------------------*/
> @@ -208,18 +163,4 @@ void storePwrIndexDiffRateOffset(struct adapter *adapter, u32 regaddr,
> #define PHY_SetRFReg(adapt, rfpath, regaddr, bitmask, data) \
> rtl8188e_PHY_SetRFReg((adapt), (rfpath), (regaddr), (bitmask), (data))
>
> -#define PHY_SetMacReg PHY_SetBBReg
> -
> -#define SIC_HW_SUPPORT 0
> -
> -#define SIC_MAX_POLL_CNT 5
> -
> -#define SIC_CMD_READY 0
> -#define SIC_CMD_WRITE 1
> -#define SIC_CMD_READ 2
> -
> -#define SIC_CMD_REG 0x1EB /* 1byte */
> -#define SIC_ADDR_REG 0x1E8 /* 1b9~1ba, 2 bytes */
> -#define SIC_DATA_REG 0x1EC /* 1bc~1bf */
> -
> #endif /* __INC_HAL8192CPHYCFG_H */
>
Acked-by: Michael Straube <straube.linux@gmail.com>
next prev parent reply other threads:[~2021-10-17 11:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 11:30 [PATCH 0/8] staging: r8188eu: another round of removals Martin Kaiser
2021-10-16 11:30 ` [PATCH 1/8] staging: r8188eu: remove empty trigger gpio code Martin Kaiser
2021-10-17 11:23 ` Michael Straube
2021-10-16 11:30 ` [PATCH 2/8] staging: r8188eu: interface type is always usb Martin Kaiser
2021-10-17 11:46 ` Michael Straube
2021-10-16 11:30 ` [PATCH 3/8] staging: r8188eu: remove two checks that are always false Martin Kaiser
2021-10-17 11:48 ` Michael Straube
2021-10-16 11:30 ` [PATCH 4/8] staging: r8188eu: remove unused function prototypes Martin Kaiser
2021-10-17 11:50 ` Michael Straube
2021-10-16 11:30 ` [PATCH 5/8] staging: r8188eu: PHY_SetRFPathSwitch_8188E is not used Martin Kaiser
2021-10-17 11:53 ` Michael Straube
2021-10-16 11:30 ` [PATCH 6/8] staging: r8188eu: clean up Hal8188EPhyCfg.h Martin Kaiser
2021-10-17 11:54 ` Michael Straube [this message]
2021-10-16 11:30 ` [PATCH 7/8] staging: r8188eu: remove procfs functions Martin Kaiser
2021-10-17 11:56 ` Michael Straube
2021-10-16 11:30 ` [PATCH 8/8] staging: r8188eu: CurrentWirelessMode is not used Martin Kaiser
2021-10-17 11:57 ` Michael Straube
2021-10-16 15:34 ` [PATCH 0/8] staging: r8188eu: another round of removals Phillip Potter
2021-10-16 16:33 ` Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88147425-3137-53d9-3cba-2c52d8ac1556@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox