From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD3801C13 for ; Fri, 5 Aug 2022 16:43:53 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id r4so4049983edi.8 for ; Fri, 05 Aug 2022 09:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=RjlAE1bDXXp4HDJF+2mcQXBU2IPR7RnkcGIixgvhqQE=; b=QdolgzFU7nxQe/dQ2LOhT1Yg7cAzE0MdA+20Mp50S1fk7aPCiJmmBAhP/XQxOtOBeQ mHU2vDwtZpUQbV+dp9lteDW9Xvygr7yEtzaeyd3XvYOpwwAwO7XmPz+g/oDXp++26btk BWXVv2w49lrw+/VkrszLSDCEQ+JWE6sJtp7N2CnQ5ODOd7uOCoByulXzr36RdoJNxV5S UcsFwJTjiqDBakf58sxyf/gOB7GJBPZExk8lE6YYUXiM6QAgqUa/K9eo8YzcnlpMUWsA Ykoq95p92BquHw2Dk3IUa+alHPfimQt+NEGPoCgUE9XroSqY8ajpVKbylNbdWgFCcWCk OVIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=RjlAE1bDXXp4HDJF+2mcQXBU2IPR7RnkcGIixgvhqQE=; b=TNUdPDuIT+tMQLWkW/fZv0uA5lnUM0dQ94YSKW+wAYFs/dGeJqMSeeM57TvUFjGEND EXIhQISbF7E8EfqRvFkdQLNTto84Je3s9E3tY4wdBECJwRqUHcRRJxr837ItgQysWDdl Z82VKr2LKz+2ek8cE6aSEYxRU0yZw2fxy59JlVE24sGd7o1dqZAvQppBtQxztOfo5Y5+ B4OBwcKrvawMA+P++OL01wAzL0cZjASSHA+ZMVev1MSXMDSECc80UO+xtP/BKRJL6XDh 7m+cvJh5fRyLeVRzALaYvCK/W+XQ8egnjPmvtA6K5sSSiZcheBN4cfNfMJqghfJ890sS J0Fg== X-Gm-Message-State: ACgBeo1MykzYc78PxFsamVqF8THt6Cfi6Gzw7x1wNcDijEjpaKvEEPIt xaUg9967N6hYW1r4f4f+PtM= X-Google-Smtp-Source: AA6agR69m7IIA5pQgvBv/jXnWdN7mZ7yFkL9gscYsV7z9vVAK2xMr1Hdzt0ovu0Yh9b/gEFUgvnB1A== X-Received: by 2002:a05:6402:2b88:b0:43a:6c58:6c64 with SMTP id fj8-20020a0564022b8800b0043a6c586c64mr7516817edb.348.1659717832106; Fri, 05 Aug 2022 09:43:52 -0700 (PDT) Received: from [192.168.1.103] (p54a07b82.dip0.t-ipconnect.de. [84.160.123.130]) by smtp.gmail.com with ESMTPSA id a15-20020a056402168f00b0043aba618bf6sm118775edv.80.2022.08.05.09.43.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 09:43:51 -0700 (PDT) Message-ID: <8b0a61dc-1d30-2731-4497-a69fff57cd2b@gmail.com> Date: Fri, 5 Aug 2022 18:43:47 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 0/4] staging: r8188eu: cleanup some metadata issues Content-Language: en-US To: Grzegorz Szymaszek , Larry Finger , Greg KH , Phillip Potter , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev References: From: Philipp Hortmann In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/5/22 18:27, Grzegorz Szymaszek wrote: > This patchset tries to improve the r8188eu driver metadata. Some > hardcoded values are replaced with proper macros, some unnecessary > macros are removed. > > Changes for v2: > - added a cover letter and a base tree reference; > - added Philipp Hortmann's Tested-by; > - replaced the second and the third patch with different ones, per Greg > Kroah-Hartman's suggestions to make better use of existing kernel > macros and remove unnecessary ones. > > Grzegorz Szymaszek (4): > staging: r8188eu: set firmware path in a macro > staging: r8188eu: use KBUILD_MODNAME instead of a string constant > staging: r8188eu: drop the DRV_NAME macro > staging: r8188eu: drop the DRIVERVERSION macro > > drivers/staging/r8188eu/core/rtw_fw.c | 2 +- > drivers/staging/r8188eu/include/drv_types.h | 4 +--- > drivers/staging/r8188eu/os_dep/os_intfs.c | 3 +-- > drivers/staging/r8188eu/os_dep/usb_intf.c | 2 +- > 4 files changed, 4 insertions(+), 7 deletions(-) > > > base-commit: 9de1f9c8ca5100a02a2e271bdbde36202e251b4b > prerequisite-patch-id: 79964bd0bcd260f1df53830a81e009c34993ee6f Tested-by: Philipp Hortmann # Edimax N150