From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from relay3.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1C3B2F33
	for <linux-staging@lists.linux.dev>; Mon, 11 Jul 2022 20:55:33 +0000 (UTC)
Received: from omf12.hostedemail.com (a10.router.float.18 [10.200.18.1])
	by unirelay10.hostedemail.com (Postfix) with ESMTP id B2B595F8;
	Mon, 11 Jul 2022 20:55:26 +0000 (UTC)
Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA id 409621B;
	Mon, 11 Jul 2022 20:55:25 +0000 (UTC)
Message-ID: <93dc367b01cdfbb68e6edf7367d2f69adfb5d407.camel@perches.com>
Subject: Re: [PATCH v3] staging: qlge: Fix indentation issue under long for
 loop
From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Binyi Han
	 <dantengknight@gmail.com>
Cc: Manish Chopra <manishc@marvell.com>, GR-Linux-NIC-Dev@marvell.com, Coiby
 Xu <coiby.xu@gmail.com>, netdev@vger.kernel.org,
 linux-staging@lists.linux.dev,  linux-kernel@vger.kernel.org
Date: Mon, 11 Jul 2022 13:55:24 -0700
In-Reply-To: <YsvZuPkbwe8yX8oi@kroah.com>
References: <20220710210418.GA148412@cloud-MacBookPro>
	 <YsvZuPkbwe8yX8oi@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1-0ubuntu1 
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
X-Rspamd-Server: rspamout04
X-Rspamd-Queue-Id: 409621B
X-Spam-Status: No, score=1.09
X-Stat-Signature: chopoje3jzpy9qmb7kz8idsut8dic5gc
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Session-ID: U2FsdGVkX18/ZwN4JJSNAALDvoh6AB39oIXKePuMAwU=
X-HE-Tag: 1657572925-704760

On Mon, 2022-07-11 at 10:05 +0200, Greg Kroah-Hartman wrote:
> On Sun, Jul 10, 2022 at 02:04:18PM -0700, Binyi Han wrote:
> > Fix indentation issue to adhere to Linux kernel coding style,
> > Issue found by checkpatch. Change the long for loop into 3 lines. And
> > optimize by avoiding the multiplication.
> >=20
> > Signed-off-by: Binyi Han <dantengknight@gmail.com>
> > ---
> > v2:
> > 	- Change the long for loop into 3 lines.
> > v3:
> > 	- Align page_entries in the for loop to open parenthesis.
> > 	- Optimize by avoiding the multiplication.
>=20
> Please do not mix coding style fixes with "optimizations" or logical
> changes.  This should be multiple patches.
>=20
> Also, did you test this change on real hardware?  At first glance, it's
> not obvious that the code is still doing the same thing, so "proof" of
> that would be nice to have.

I read the code and suggested the optimization.  It's the same logic.