Re: [PATCH v4 6/6] arm64: dts: rockchip: Add rkvdec2 Video Decoder on rk3588(s)

Heiko Stübner
2025-04-08T13:16:29Z

Hi Detlev,

Am Dienstag, 25. März 2025, 22:22:22 Mitteleuropäische Sommerzeit schrieb Detlev Casanova:
> Add the rkvdec2 Video Decoder to the RK3588s devicetree.
>
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---

> + vdec1_mmu: iommu@fdc40700 {
> + compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
> + reg = <0x0 0xfdc40700 0x0 0x40>, <0x0 0xfdc40740 0x0 0x40>;
> + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&cru ACLK_RKVDEC0>, <&cru HCLK_RKVDEC0>;
> + clock-names = "aclk", "iface";
> + power-domains = <&power RK3588_PD_RKVDEC0>;
> + #iommu-cells = <0>;
> + };

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
index 24ecbff06cd27..8bde8e257eac9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
@@ -1395,7 +1395,7 @@ vdec1_mmu: iommu@fdc40700 {
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH 0>;
clocks = <&cru ACLK_RKVDEC0>, <&cru HCLK_RKVDEC0>;
clock-names = "aclk", "iface";
- power-domains = <&power RK3588_PD_RKVDEC0>;
+ power-domains = <&power RK3588_PD_RKVDEC1>;
#iommu-cells = <0>;
};

Needs to use the correct power-domain, otherwise ends in SErrors on 6.15-rc1

Heiko