From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C42319D065 for ; Tue, 24 Mar 2026 05:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774330330; cv=none; b=SvJ5laOksSSaOJl40No5R/bLai1T6VOuO/Q9nUtvo01SXBEbuE3FNFujwb3RcNLRHpzIKCqf6Zb6Dq1yMTdxFppeK36d1egGXaYNwK8KHsIbAChUeobOYzCZ3RI7MjX5vzkKZB4SYSRzpYfHoSxgSDmoPCWMKsATPd3RKGjdO3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774330330; c=relaxed/simple; bh=w3VNmjFyd5cXr07kmPWMZ6xbHhw5W061DTkjKMN+06I=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=HQOuZ6xsyGpLNrag0pVgTky7sx6gu9A/xJyu2d31oxgkfBSz2h2kRnWWRlqqWZntYNO4LKKCKF9iNMYjDtOsFg4BowdwtZoWXCLDf7wsmZpSkkZIGxmYVfVSnpeq1K7y9kUpM+UW3/IM72MpkH6e5ck18pVAhwqociy+SxJA8sg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=QBx1OUOV; arc=none smtp.client-ip=95.215.58.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QBx1OUOV" Date: Tue, 24 Mar 2026 06:31:48 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774330326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C0nSi1/doas+yHC33NcnaYhTWgGWMe7gNrtH+WkcCr4=; b=QBx1OUOVlRXHU6mXy2qzV5bqVRPzrgg3lE+MjMmjjVRl8+pC6HsdvmOD3BVidd1OjxokSB SI/st2NIyHE+s4OorIuOQjOD8avImMvUeJrC7Tt3Unphy2dlJ3tamDz5i/YLWWGqie0IYk IHZpVclHLugQX/CHQopNGSMGslzY+AE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Luka Gejak To: Aadarsh Mandal , gregkh@linuxfoundation.org CC: dan.carpenter@linaro.org, ethantidmore06@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, straube.linux@gmail.com Subject: Re: [PATCH v7] staging: rtl8723bs: remove commented-out code In-Reply-To: <20260324040718.7777-1-aadarshmandal9354@gmail.com> References: <20260318021005.6346-1-aadarshmandal9354@gmail.com> <20260324040718.7777-1-aadarshmandal9354@gmail.com> Message-ID: <996970ED-4638-4649-A4EA-ECF440E9425A@linux.dev> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT On March 24, 2026 5:07:18 AM GMT+01:00, Aadarsh Mandal wrote: >Remove code that is not used anywhere in driver=2E > >Signed-off-by: Aadarsh Mandal >--- >v6: > - No change=2E >v5: > - No change=2E >v4: > - Remove extra space insertion=2E > - Delete remaining commented-out code=2E >v3: > - Add the extra space that count as insertion=2E > - Remove unwanted addition=2E >v2: > - Restore braces for standalone code blocks {}=2E > - Delete reindented commented-out code and extra space=2E >v1: > - Reindented commented-out code;extra space remained=2E > > drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec | 17 ----------------- > 1 file changed, 17 deletions(-) > >diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec b/drivers/sta= ging/rtl8723bs/hal/sdio_halinit=2Ec >index 063a0737933e=2E=2E96a0c8e304da 100644 >--- a/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec >+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec >@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapte= r *padapter) > { > struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); > >- /* Tx aggregation setting */ >-/* sdio_AggSettingTxUpdate(padapter); */ >- > /* Rx aggregation setting */ > HalRxAggr8723BSdio(padapter); > >@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) > return _SUCCESS; > } > >- /* Disable Interrupt first=2E */ >-/* rtw_hal_disable_interrupt(padapter); */ >- > ret =3D _InitPowerOn_8723BS(padapter); > if (ret =3D=3D _FAIL) > return _FAIL; >@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) > > rtl8723b_InitializeFirmwareVars(padapter); > >-/* SIC_Init(padapter); */ >- > if (pwrctrlpriv->reg_rfoff) > pwrctrlpriv->rf_pwrstate =3D rf_off; > >@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) > rtw_hal_set_chnl_bw(padapter, padapter->registrypriv=2Echannel, > CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSE= T_DONT_CARE); > >- /* Record original value for template=2E This is arough data, we can o= nly use the data */ >- /* for power adjust=2E The value can not be adjustde according to diff= erent power!!! */ >-/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ >-/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrId= x; */ >- > rtl8723b_InitAntenna_Selection(padapter); > > /* */ >@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) > /* ack for xmit mgmt frames=2E */ > rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_T= XQ_CTRL) | BIT(12)); > >-/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_H= RPWM1) & 0x80; */ >- > { > pwrctrlpriv->rf_pwrstate =3D rf_on; > >@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapt= er) > pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; > pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; > >-/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EE= PROM_BOOT_EFUSE; */ >- > _ReadEfuseInfo8723BS(padapter); > } > >-- >2=2E43=2E0 Hi Aadarsh, It seems patch is corrupted, so please regenerate it and don't edit the fi= le manually=2E Best regards, Luka Gejak